gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

Conformance Tests: HTTPRoute Filters

Open robscott opened this issue 3 years ago • 3 comments

This issue is intended to track conformance test development for HTTPRoute filters. Comment below if you're interested in working on covering any of these areas.

Core Capabilities:

  • [x] Header modifier (@skriss)
    • [x] Set
    • [x] Add
    • [x] Remove
  • [ ] Request redirect (Prior art in https://github.com/kubernetes-sigs/ingress-controller-conformance that can serve as a starting point)
    • [ ] Scheme
    • [ ] Port Number

Extended Capabilities:

  • [ ] Request mirroring
  • [ ] Combinations of the above with core capabilities

robscott avatar Apr 08 '22 23:04 robscott

I've submitted https://github.com/kubernetes-sigs/gateway-api/pull/1163 for the header modifier set/add/remove cases.

skriss avatar May 16 '22 22:05 skriss

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 29 '22 19:09 k8s-triage-robot

/remove-lifecycle stale

mikemorris avatar Oct 04 '22 19:10 mikemorris

I think this issue should be augmented (or another created) to add testing for HTTPRoute Filters per-BackendRef as well, since the existing tests only test per-RouteRule

Part of that will include adding a test helper that can conditionally check a response has the correct content, given it was routed to a particular backend

sunjayBhatia avatar Nov 09 '22 16:11 sunjayBhatia

@LiorLieberman is working on conformance tests for HTTP Redirects.

robscott avatar Nov 14 '22 22:11 robscott

@robscott is request conformance for request mirroring still wanted?

also proposing changes to the description

...

Extended Capabilities: Request Redirect: (@LiorLieberman) [x] Scheme [x] Port Number

Experimental Capabilities: Request Redirect: [x] Path Request Rewrite: (@LiorLieberman ) [x] host [x] Path

...

LiorLieberman avatar Feb 08 '23 15:02 LiorLieberman

Thanks @LiorLieberman! Updated the issue to match. We are still looking for tests covering request mirroring.

robscott avatar Feb 09 '23 00:02 robscott

At this point we only have one item left, talked with @robscott he's gonna close this and spin off the last one.

/assign @robscott

shaneutt avatar May 18 '23 16:05 shaneutt

What is the one item left? @shaneutt

LiorLieberman avatar May 18 '23 16:05 LiorLieberman

@LiorLieberman added https://github.com/kubernetes-sigs/gateway-api/issues/2037 to track the last part of this (combining HTTPRoute filters together in tests).

Going to close this one out in favor of that more specific one.

robscott avatar May 18 '23 19:05 robscott