external-dns icon indicating copy to clipboard operation
external-dns copied to clipboard

fix: output the name of the worker to console when added

Open BobVanB opened this issue 8 months ago • 6 comments
trafficstars

Description

Change the output in the console for debugging purpose.

time="2025-02-24T05:59:44+01:00" level=debug msg="node added"
time="2025-02-24T05:59:44+01:00" level=debug msg="node added"
time="2025-02-24T05:59:44+01:00" level=debug msg="node added"

vs.

time="2025-02-24T05:59:44+01:00" level=debug msg="Node added: myworker1"
time="2025-02-24T05:59:44+01:00" level=debug msg="Node added: myworker2"
time="2025-02-24T05:59:44+01:00" level=debug msg="Node added: myworker3"

The output is rather fun if there are 400+ workers and you only see node added.

Checklist

  • [ ] Unit tests updated
  • [X] End user documentation updated

BobVanB avatar Feb 24 '25 05:02 BobVanB

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign raffo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 24 '25 05:02 k8s-ci-robot

Hi @BobVanB. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Feb 24 '25 05:02 k8s-ci-robot

/ok-to-test

ivankatliarchuk avatar Feb 24 '25 08:02 ivankatliarchuk

/label tide/merge-method-squash

ivankatliarchuk avatar Feb 26 '25 07:02 ivankatliarchuk

Currently a little occupide, i will work on it when i have the time. It is not something critical. Rather do it well and then merge it.

BobVanB avatar Feb 26 '25 08:02 BobVanB

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 27 '25 08:05 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jun 26 '25 09:06 k8s-triage-robot

/close

ivankatliarchuk avatar Jun 26 '25 14:06 ivankatliarchuk

@ivankatliarchuk: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 26 '25 14:06 k8s-ci-robot