external-dns icon indicating copy to clipboard operation
external-dns copied to clipboard

feat: log when endpoint ignored due to ownerid not match

Open davhdavh opened this issue 1 year ago • 3 comments

Description

Log when dropping create items due to no match for owner id.

Fixes #4814

Checklist

  • [ ] Unit tests updated
  • [ ] End user documentation updated

davhdavh avatar Oct 17 '24 06:10 davhdavh

Hi @davhdavh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Oct 17 '24 06:10 k8s-ci-robot

/ok-to-test

mloiseleur avatar Oct 17 '24 14:10 mloiseleur

/lgtm

mloiseleur avatar Oct 27 '24 13:10 mloiseleur

/approve /lgtm

Raffo avatar Oct 30 '24 17:10 Raffo

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 30 '24 17:10 k8s-ci-robot