external-dns
external-dns copied to clipboard
kubernetes-sigs
fix(aws): add soft error
Description
Fixes (again) #4067 because it was partly revert by #3973.
Add the ability to have a soft error when it fails to list resource records sets for zone. For example, if the cause of the error is the throttling of the AWS Route53 API Throttling: Rate exceeded' status code: 400 , it is certainly not helpful if it is not a soft error and flags to improve the situation such as --min-event-sync-interval can not work.
Checklist
- [ ] Unit tests updated
- [ ] End user documentation updated -> Both are not needed
Welcome @blanchardma!
It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @blanchardma. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@blanchardma thanks for this. Would you please update the tests accordingly ?
@mloiseleur can you be a bit more specific? Because the other PR #3973 in this direction don't have any and also the one that introduced the softerror #4166.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: szuecs
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [szuecs]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@mloiseleur can you be a bit more specific? Because the other PR #3973 in this direction don't have any and also the one that introduced the softerror #4166.
For example https://github.com/kubernetes-sigs/external-dns/pull/4682
@blanchardma https://github.com/kubernetes-sigs/external-dns/pull/4741#issuecomment-2359204348 can you check that?
@mloiseleur: The label(s) /label contributor/waiting-for-feedback cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?
In response to this:
/label contributor/waiting-for-feedback
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@mloiseleur: The label(s) /label need-change cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?
In response to this:
/label need-change
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@mloiseleur: The label(s) /label needs-change cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?
In response to this:
/label needs-change
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
I tried to add some labels on this PR, without any success :sweat_smile: . Sorry for the noise :bow: .
It seems there hasn't been an update from @blanchardma for a while. @szuecs and @mloiseleur, what are your suggestions for moving this forward? The fix would be really helpful.
@szuecs @mloiseleur Thanks for the feedback. I absolutely support the question regarding tests. From my point of view, the requested test cannot be solved cleanly without a lot of changes in other tests. But of course I still offer my PR as it is to close this bug.
@ninjaprox You can open a new PR, based on this PR, and add tests.
@mloiseleur Thanks, I open https://github.com/kubernetes-sigs/external-dns/pull/4886 with tests added. Could you take a look?