external-dns icon indicating copy to clipboard operation
external-dns copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Feature: add cloudflare host name

Open AndrewCharlesHay opened this issue 1 year ago • 8 comments

Description

I am trying to add the option to pass in Cloudflare region. This is a work in progress. This definitely doesn't work yet, just showing what I was thinking if someone wants to point me in the right direction

Fixes #4644

Checklist

  • [x] Unit tests updated
  • [x] End user documentation updated

AndrewCharlesHay avatar Jul 31 '24 18:07 AndrewCharlesHay

Hi @AndrewCharlesHay. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 31 '24 18:07 k8s-ci-robot

@johngmyers or @mloiseleur how do I run tests for this? How does the PR look?

AndrewCharlesHay avatar Sep 06 '24 21:09 AndrewCharlesHay

/ok-to-test Please remove the content of devcontainer.json of this PR. You can submit it in an other PR.

mloiseleur avatar Sep 14 '24 11:09 mloiseleur

@mloiseleur I removed the devcontainer.json and made a separate PR here. I'll fix the failing tests. Thanks for adding the ability to run the tests

AndrewCharlesHay avatar Sep 14 '24 23:09 AndrewCharlesHay

The tests are still red on this one.

Raffo avatar Oct 03 '24 16:10 Raffo

The tests are still red on this one.

@Raffo Yeah sorry I haven't had too much time to work on this. Do you have advice on testing this new endpoint?

AndrewCharlesHay avatar Oct 04 '24 17:10 AndrewCharlesHay

@Raffo & @johngmyers I fixed the tests! Let me know if everything looks good

AndrewCharlesHay avatar Oct 11 '24 15:10 AndrewCharlesHay

@Raffo or @johngmyers Any update?

AndrewCharlesHay avatar Oct 28 '24 16:10 AndrewCharlesHay

/retitle feat(cloudflare): support cloudflare region

mloiseleur avatar Nov 01 '24 10:11 mloiseleur

It looks better, now :+1: .

Would you please rebase and add some documentation on how to use it ?

mloiseleur avatar Nov 01 '24 10:11 mloiseleur

🇪🇺 I added your region as the host for the example @mloiseleur 😉 How does the updated documentation look to you?

AndrewCharlesHay avatar Nov 01 '24 16:11 AndrewCharlesHay

/lgtm

mloiseleur avatar Nov 02 '24 09:11 mloiseleur

/lgtm /assign @Raffo

mloiseleur avatar Nov 03 '24 09:11 mloiseleur

/approve

Raffo avatar Nov 04 '24 17:11 Raffo

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 04 '24 17:11 k8s-ci-robot

Thank you both for your support! Do you have an idea on when the next release will be?

AndrewCharlesHay avatar Nov 06 '24 14:11 AndrewCharlesHay

@AndrewCharlesHay I expect to do a release in early December.

Raffo avatar Nov 12 '24 10:11 Raffo