external-dns
external-dns copied to clipboard
kubernetes-sigs
rfc2136: merge Endpoints with same name/type into single Endpoint
Description
Rebased and reopened no longer maintained https://github.com/kubernetes-sigs/external-dns/pull/1678 Related https://github.com/kubernetes-sigs/external-dns/issues/1596
Map multiple DNS records with the same name/type into the external-dns which models such records as a single Endpoint with multiple entries in the Targets attribute.
Solution: Generalize the solution introduced to the DigitalOcean provider by #1595 by refactoring the mergeEndpointsByNameType function into the endpoint module. Then use that function in the RFC2136 provider.
Fixes #1596
Checklist
- [x] Unit tests updated
- [x] End user documentation updated
- [ ] Tested with RFC2136 provider in a real deployment
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign mloiseleur for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Welcome @bogdando!
It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @bogdando. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
I checked that this works for rfc2136 provider with endpoints list of a ~700 records, but all targets have a length of 1. It works without problems, or regressions. I don't have ideas how to make an artificial scenario with target len > 1. I hope unit tests coverage is sufficient for such a case.
@tdyas FYI
@bogdando Would you please remove the line on the changelog ? Otherwise, the pr looks good.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Since there is no answer since a few month, I close it. Feel free to re-open it if needed. /close
@mloiseleur: Closed this PR.
In response to this:
Since there is no answer since a few month, I close it. Feel free to re-open it if needed. /close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.