external-dns icon indicating copy to clipboard operation
external-dns copied to clipboard

Update cloudflare.md

Open tobiabocchi opened this issue 1 year ago • 4 comments

Hey! I was trying out external-dns using cloudflare. I followed your docs and managed to deploy it successfully on my k3s cluster. While reading the docs and copying pasting the yaml files I noticed there was some inconsistencies with the indentation.. I am no kubernetes expert, I just fixed the problems that were not allowing me to deploy this service and checked the files using yamllint.com While I was at it I also noticed a few errors on the syntax highlighting for code blocks, some had shell where the content was yaml, I fixed those too.. I hope this helps, thank you for this amazing project!

Description

Fixes #ISSUE

Checklist

  • [ ] Unit tests updated
  • [ ] End user documentation updated

tobiabocchi avatar Jun 29 '24 13:06 tobiabocchi

Welcome @tobiabocchi!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Jun 29 '24 13:06 k8s-ci-robot

Hi @tobiabocchi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 29 '24 13:06 k8s-ci-robot

Thanks @tobiabocchi, you're right. It's far better with correct indentation :+1:. /lgtm /approve

mloiseleur avatar Jul 04 '24 22:07 mloiseleur

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 04 '24 22:07 k8s-ci-robot