fix(azure): fix `external_dns_registry_errors_total` metrics counter value 0

[dongjiang1989]

Description

The Azure provider should increment external_dns_registry_errors_total when changes cannot be submitted(found, updated, deleted, or created).

Fixes #4510

Checklist

• [x] Unit tests updated
• [x] End user documentation updated

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign mloiseleur for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @dongjiang1989. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dongjiang1989]

@mloiseleur PTAL

[mloiseleur]

Thanks for this PR. Do you think you can add a test to ensure it won't happen again ?

[dongjiang1989]

Thanks for this PR. Do you think you can add a test to ensure it won't happen again ?

Hmmm... It seems difficult to add unittest case. https://github.com/kubernetes-sigs/external-dns/blob/e6a3571d5ea4748abb3e6eb62b84a10242d96d68/controller/controller.go#L206-L211

https://github.com/kubernetes-sigs/external-dns/blob/939e7b8e913e49a1256fe43606d0a683d8d127ad/controller/controller.go#L251-L256

Is there any better suggestion to add unittest case? 🤔️ @mloiseleur just return errror cases. PTAL

[dongjiang1989]

@mloiseleur @szuecs PTAL re-check

[mloiseleur]

/ok-to-test

[dongjiang1989]

Thanks. @mloiseleur @szuecs Please re-check

[mloiseleur]

/lgtm

[dongjiang1989]

@mloiseleur Do you agree to Merge it? Thanks

[mloiseleur]

@dongjiang1989 An other maintainer will do the final review when he has time. Thanks for your understanding.

[dongjiang1989]

cc @agimenoapinity

[dongjiang1989]

@johngmyers @szuecs PTAL, when you hava time. thanks.

[mloiseleur]

/retitle fix(Azure DNS): external_dns_registry_errors_total metrics counter value

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.