external-dns icon indicating copy to clipboard operation
external-dns copied to clipboard

fix: add clarification to endpoint unit tests

Open leonardocaylent opened this issue 1 year ago • 6 comments

Description

Based on the conversation during #4296 this is an addition to clarify that A records cannot live with CNAME records with the same hostnames. Since the function that was developed is not expected to validate the type of records, this unit test was splitted into 2 different Record types to avoid any type of possible confusion in the future.

Fixes #4339

Checklist

  • [x] Unit tests updated
  • [ ] End user documentation updated

leonardocaylent avatar May 11 '24 23:05 leonardocaylent

Hi @leonardocaylent. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 11 '24 23:05 k8s-ci-robot

This is ready to be tested and is just a complement of #4241

leonardocaylent avatar May 12 '24 00:05 leonardocaylent

/ok-to-test

mloiseleur avatar May 13 '24 06:05 mloiseleur

This is ready to review

leonardocaylent avatar May 13 '24 13:05 leonardocaylent

/lgtm

mloiseleur avatar May 13 '24 13:05 mloiseleur

/approve

Raffo avatar May 16 '24 08:05 Raffo

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 16 '24 08:05 k8s-ci-robot