external-dns
external-dns copied to clipboard
feat(webhooks): pass webhook-* annotations to webhook providers
Description
Fixes https://github.com/kubernetes-sigs/external-dns/issues/4367
This PR allows to forward specific implementations to webhook implementations so that they can make use of them.
@hans-m-song is this what you expected?
Checklist
- [ ] Unit tests updated
- [ ] End user documentation updated
Wdyt about adding a few words about this in the documentation ? Otherwise, lgtm.
I have a suggestion for the title of this PR:
feat(webhooks): pass webhook-* annotations to webhook providers
@mloiseleur yes, 100% happy to add more info. I was more wondering "is this enough" and hence why I opened it like this. I'd say that it looks enough and I'm kind of embarrassed I didn't think about it when I first worked on the webhook. Do you see anything that needs to be added for this feature to satisfy the original issue?
@mloiseleur added some docs.
Nope. /lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Raffo
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [Raffo]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment