external-dns icon indicating copy to clipboard operation
external-dns copied to clipboard

feat(webhooks): pass webhook-* annotations to webhook providers

Open Raffo opened this issue 1 year ago • 4 comments

Description

Fixes https://github.com/kubernetes-sigs/external-dns/issues/4367

This PR allows to forward specific implementations to webhook implementations so that they can make use of them.

@hans-m-song is this what you expected?

Checklist

  • [ ] Unit tests updated
  • [ ] End user documentation updated

Raffo avatar May 11 '24 12:05 Raffo

Wdyt about adding a few words about this in the documentation ? Otherwise, lgtm.

mloiseleur avatar May 13 '24 06:05 mloiseleur

I have a suggestion for the title of this PR:

feat(webhooks): pass webhook-* annotations to webhook providers

mloiseleur avatar May 13 '24 06:05 mloiseleur

@mloiseleur yes, 100% happy to add more info. I was more wondering "is this enough" and hence why I opened it like this. I'd say that it looks enough and I'm kind of embarrassed I didn't think about it when I first worked on the webhook. Do you see anything that needs to be added for this feature to satisfy the original issue?

Raffo avatar May 18 '24 07:05 Raffo

@mloiseleur added some docs.

Raffo avatar May 24 '24 15:05 Raffo

Nope. /lgtm

mloiseleur avatar May 24 '24 15:05 mloiseleur

/approve

Raffo avatar May 24 '24 15:05 Raffo

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 24 '24 15:05 k8s-ci-robot