[WIP] docs: remove tenantId from external-dns-azure secret

[sanketnadkarni]

trafficstars

Description

Removing tenantId in the Secret that is to be created for deploying external-dns with Helm in Azure with Managed Identities using Workload Identity

With tenantId present in the Secret the external-dns pods run into CrashLoopBackOff with following error:

time="2024-04-25T06:34:37Z" level=fatal msg="WorkloadIdentityCredential: unable to resolve an endpoint: http call(https://login.microsoftonline.com/XXXXX-REDACTED-XXXXXX/v2.0/.well-known/openid-configuration)(GET) error: reply status code was 400:\n{\"error\":\"invalid_tenant\",\"error_description\":\"AADSTS90002: Tenant 'XXXXX-REDACTED-XXXXXX' not found. Check to make sure you have the correct tenant ID and are signing into the correct cloud. Check with your subscription administrator, this may happen if there are no active subscriptions for the tenant. Trace ID: 56aa0372-738d-43ae-896d-d4fa9eb92101 Correlation ID: 45d49251-1a76-4be5-ac80-e6829e8c4bed Timestamp: 2024-04-25 06:34:37Z\",\"error_codes\":[90002],\"timestamp\":\"2024-04-25 06:34:37Z\",\"trace_id\":\"56aa0372-738d-43ae-896d-d4fa9eb92101\",\"correlation_id\":\"45d49251-1a76-4be5-ac80-e6829e8c4bed\",\"error_uri\":\"https://login.microsoftonline.com/error?code=90002\"}"

Error Details: https://login.microsoftonline.com/error?code=90002

The above error is also seen when you try to login using azcli from a pod with same service account and namespace using federated credentials:

~ # az login --federated-token "$(cat ${AZ_TOKEN})" --service-principal -u XXXX-MANAGEDIDENTITY-XXXX  -t XXXXX-REDACTED-XXXXXX
Failed to resolve tenant 'XXXXX-REDACTED-XXXXXX'.

Error detail: {"error":"invalid_tenant","error_description":"AADSTS90002: Tenant 'XXXXX-REDACTED-XXXXXX' not found. Check to make sure you have the correct tenant ID and are signing into the correct cloud. Check with your subscription administrator, this may happen if there are no active subscriptions for the tenant. Trace ID: 6ac60ea5-e0f8-4267-9f66-a02110b53300 Correlation ID: 0a1d6bf7-168c-4840-946d-4b116b9c28e1 Timestamp: 2024-04-25 09:47:44Z","error_codes":[90002],"timestamp":"2024-04-25 09:47:44Z","trace_id":"6ac60ea5-e0f8-4267-9f66-a02110b53300","correlation_id":"0a1d6bf7-168c-4840-946d-4b116b9c28e1","error_uri":"https://login.microsoftonline.com/error?code=90002"}

We were able to fix this after removing tenantId field from the Secret external-dns-azure, as it was not seen in the kubectl patch commands that create the same Secret using kubectl as alternative method, in the same document

Checklist

• [x] Unit tests updated
• [x] End user documentation updated

[linux-foundation-easycla[bot]]

• :x: The email address for the commit (e232b3ced3f85587e50dbb6a71211099571ea43e) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign szuecs for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @sanketnadkarni!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

Hi @sanketnadkarni. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten