external-dns
external-dns copied to clipboard
kubernetes-sigs
feat(rfc2136): add PTR optional support
Description
The PR extends the existing RFC2136 provider within external-dns, incorporating logic to handle PTR record creation and deletion alongside the management of other DNS record types. The functionality is disabled by default and can be activated with --rfc2136-create-ptr (similar to infoblox flag) in order to keep current behaviour during an upgrade.
Checklist
- [x] End user documentation updated
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: angeloxx / name: angeloxx (a0040a46035e73a7c2aa0d007b723877551d3130, 0efdfb3488cb19267f5fb15b71a35a1e8012b4cd, b083e34dfb8b27a699108294a6a10c806f73c27f, 5c01e953b43fdee5b25857ef329f7dc3caa25b2c, 2f7f6390d003b3f1508ba95f88db587609e57725, 940899b7583fa670ee57df9bc3aeecf39c55836f, bab7a84f11189d817749fb8dbd8609162cef78e2, cd2088dff30b161dba3e86a10277a535fddd23f8, 1d93309e7fde3f1a5c5bc6f8439e37292e2ad3e5)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @angeloxx!
It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @angeloxx. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@angeloxx: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/test all
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@angeloxx: you cannot LGTM your own PR.
In response to this:
/lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/ok-to-test Thanks. The PR looks good, comes with test and is documented.
I don't see a test that checks that PTR is enabled and we got a PTR record.
You're right, I just added a test that verifies the (correct) creation of a reverse.
fr: would be great if we could use an annotation per source i.e "external-dns.alpha.kubernetes.io/rfc2136-create-ptr: true/false" that would stand above global --rfc2136-create-ptr, so we would have more elasticity
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: szuecs
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [szuecs]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@chrxmvtik please add an issue or PR to define or implement this feature. It sounds that it could be helpful for the ones that need PTR record support.