custom Azure Active Directory Authority Host

[Jeremy-Boyle]

Description This allows custom Azure Active Directory Authority Host field to be set, this allows the configuration of the value and enables externaldns to work in private Azure environments that are not apart of the Azure SDK.

Looking for feedback on how i went about adding the fix, open to suggestions / improvements if the env route is undesired.

Inspiration for the env: https://learn.microsoft.com/en-us/azure/developer/go/azure-sdk-authorization#authentication-on-azure-stack

Issue in Azure Cloud ADK: https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/[email protected]/cloud#pkg-variables

Fixes #4209

Checklist

• [x] Unit tests updated
• [ ] End user documentation updated (TODO)

[k8s-ci-robot]

Welcome @Jeremy-Boyle!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

Hi @Jeremy-Boyle. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[szuecs]

/ok-to-test /approve /lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [szuecs]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[szuecs]

https://github.com/kubernetes-sigs/external-dns/issues/4240

[szuecs]

please rebase the test was fixed

[Jeremy-Boyle]

Rebased

[mloiseleur]

@Jeremy-Boyle Wdyt of @pascalgn comment ? BTW, Would you please update the documentation about this new settings ?

[Jeremy-Boyle]

I haven't had a response back, I'm going to do the suggestion.

[Jeremy-Boyle]

@szuecs @pascalgn

Does this look good now with your recommendations ?

[pascalgn]

Thanks for updating, I like the PR much better now. To me the PR looks good!

[szuecs]

/lgtm

@Jeremy-Boyle @pascalgn I guess it makes sense to add the docs, but maybe we just do it in another PR to save some time.

[Jeremy-Boyle]

@szuecs

Is there a issue that you know of or a roadmap of when 0.14.2 will be released ? I'm assuming this would be the next release with these changes added.