external-dns
external-dns copied to clipboard
kubernetes-sigs
feat: initial OpenAPI spec for webhook provider
This provides the initial OpenAPI doc describing the webhook API as described in the code. Really need far better descriptions for each endpoint and for each element in the schemas.
The goal is to make it far easier to implement providers. I'm using a similar document here
Relates to #4138
Not a goal for this PR, but possibly for a future one is to generate the webhook client with oapi-codegen.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: lyda / name: Kevin Lyda (4a56946057417a0e0309ffdc96bec38a22026dcc, bdc6bd6ac89c860dca27925c4bd5342566d93307, 44055609d91aa03e049aebf889e79940b64dd04a, 2569f62a253329814b9100fb654da9f0e9fa0193, e060348e7e69914865593151417ec4f4f10708b1, 9b7f76cb47f0da291bc85d134722b312aafee46f)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @lyda!
It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @lyda. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
\o many thanks for this PR !
Do you think you can add in this PR:
- a linter test, for instance with vacuum
- integrate this spec with unit test, to ensure real validation
Didn't know vacuum - will definitely add that.
Ideas for the second one? I know prism can run in proxy mode to do this. Any other tools you can suggest?
On Thu 4 Jan 2024, 07:38 Michel Loiseleur, @.***> wrote:
\o many thanks for this PR !
Do you think you can add in this PR:
- a linter test, for instance with vacuum https://github.com/daveshanley/vacuum
- integrate this spec with unit test, to ensure real validation
— Reply to this email directly, view it on GitHub https://github.com/kubernetes-sigs/external-dns/pull/4148#issuecomment-1876620724, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFOLDHRJ5SVWAYNP7LLDYLYMZMAFAVCNFSM6AAAAABBLEMWMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZWGYZDANZSGQ . You are receiving this because you were mentioned.Message ID: @.***>
I can suggest either https://github.com/getkin/kin-openapi or https://pb33f.io/libopenapi/.
It may help also to serve the spec on a http path like /spec/openapi.yaml.
Sorry, @mloiseleur can you confirm my descriptions? I've reviewed a few webook providers and think I have them. I'm still a little unclear what POST /adjustendpoints is for. And I think my description of POST /records is correct, but would appreciate a confirmation. Thanks!
BTW, I'm using this for a provider for my home lab and so far has worked well.
OK, added the linter spec - I think correctly. Not used to github workflows as I've mainly used gitlab for the past decade.
Will look at the unit test changes but likely not till next weekend. Will also look at serving it.
Cool. I think I have a version that fixes the warnings. Will do it this evening.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from raffo. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi,
I started to implement a provider from the openapi spec, and i found some few things.
- required fields are not declared
- in the structure Changes the first field is "create", but edns send "Create"
regards,
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten