external-dns icon indicating copy to clipboard operation
external-dns copied to clipboard

cloudflare: support comment field

Open cyclingwithelephants opened this issue 2 years ago • 12 comments
trafficstars

What would you like to be added: cloudflare offer comments attached to their DNS records, up to 100 characters. It would be great to be able to configure this using a external-dns.alpha.kubernetes.io/cloudflare- style annotation, or potentially a CLI flag.

Why is this needed: This would help to make explicit the DNS records that are externally managed, the last time they were updated, perhaps their cluster, etc.

cyclingwithelephants avatar Sep 15 '23 23:09 cyclingwithelephants

I can work on this issue. Let me know if it is accepted.

MaGaroo avatar Sep 16 '23 11:09 MaGaroo

Sounds like that would be a good place to put the labels, so one could use the noop registry.

johngmyers avatar Sep 19 '23 05:09 johngmyers

Aren't record-tags better to store labels then?

davidegirardi avatar Sep 19 '23 12:09 davidegirardi

May well be. I don't know much about Cloudflare.

johngmyers avatar Sep 19 '23 17:09 johngmyers

The comment is a string and tags is an array of strings in the request body. They have limitations depending on the subscription in use.

davidegirardi avatar Sep 20 '23 08:09 davidegirardi

I would very much like to be able to use the comment field instead of TXT records as registry. To make this compatible with all Cloudflare subcriptions, it should however be <= 100 characters.

morremeyer avatar Oct 06 '23 15:10 morremeyer

Is somebody working on this?

matrix-root avatar Nov 13 '23 00:11 matrix-root

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Feb 11 '24 00:02 k8s-triage-robot

Not stale, I might get to work on this soon-ish.

morremeyer avatar Feb 11 '24 07:02 morremeyer

/remove-lifecycle stale

morremeyer avatar Feb 11 '24 07:02 morremeyer

It would be really great to have support for Cloudflare Tags as well, as these are more useful because of being able to search and group based on them. Example when you have a large zone where not everything is managed by external-dns, being able to see quickly at a glance what is managed by external-dns and what is terraform via tags would be useful.

Example.... image

andyr8939 avatar Mar 03 '24 22:03 andyr8939

Is somebody working on this?

stepanbaghdasaryan avatar May 05 '24 08:05 stepanbaghdasaryan

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 03 '24 08:08 k8s-triage-robot

/remove-lifecycle stale

morremeyer avatar Aug 03 '24 08:08 morremeyer

Hi, is this being considered? Can we make a contribution here? In the end even if you have an enterprise level subscription, tags and comments can be optional.

xaoo avatar Sep 11 '24 13:09 xaoo