external-dns
external-dns copied to clipboard
test: controller run() should do somthing and successfully shutdown
test: controller run() should do somthing and successfully shutdown
/ok-to-test
/lgtm
@szuecs: you cannot LGTM your own PR.
In response to this:
/lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@szuecs Wdyt of @johngmyers comments ?
@mloiseleur changed the code to fix all comments by @johngmyers
/lgtm
/assign @Raffo for final review
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
/remove-lifecycle stale
/retitle test: controller run() and successfully shutdown
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Raffo
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [Raffo]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment