external-dns icon indicating copy to clipboard operation
external-dns copied to clipboard

test: controller run() should do somthing and successfully shutdown

Open szuecs opened this issue 2 years ago • 10 comments
trafficstars

test: controller run() should do somthing and successfully shutdown

szuecs avatar May 26 '23 21:05 szuecs

/ok-to-test

szuecs avatar May 26 '23 21:05 szuecs

/lgtm

szuecs avatar May 26 '23 21:05 szuecs

@szuecs: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar May 26 '23 21:05 k8s-ci-robot

@szuecs Wdyt of @johngmyers comments ?

mloiseleur avatar Oct 27 '23 11:10 mloiseleur

@mloiseleur changed the code to fix all comments by @johngmyers

szuecs avatar Jan 05 '24 19:01 szuecs

/lgtm

mloiseleur avatar Jan 15 '24 07:01 mloiseleur

/assign @Raffo for final review

mloiseleur avatar Jan 15 '24 07:01 mloiseleur

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 14 '24 07:04 k8s-triage-robot

/remove-lifecycle stale

szuecs avatar Apr 25 '24 14:04 szuecs

/retitle test: controller run() and successfully shutdown

mloiseleur avatar May 03 '24 11:05 mloiseleur

/approve

Raffo avatar May 03 '24 19:05 Raffo

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 03 '24 19:05 k8s-ci-robot