external-dns icon indicating copy to clipboard operation
external-dns copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Log when infoblox provider deletes a record at info

Open gregsidelinger opened this issue 3 years ago • 4 comments

Signed-off-by: Greg Sidelinger [email protected]

Description

Fixes #ISSUE

Checklist

  • [x] Unit tests updated
  • [x] End user documentation updated

gregsidelinger avatar Sep 06 '22 13:09 gregsidelinger

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gregsidelinger Once this PR has been reviewed and has the lgtm label, please assign njuettner for approval by writing /assign @njuettner in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 06 '22 13:09 k8s-ci-robot

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: gregsidelinger / name: Greg (18fd5b1af6a7a0dede3e15fcfe1b7f5bd1ee9b35)

linux-foundation-easycla[bot] avatar Sep 06 '22 13:09 linux-foundation-easycla[bot]

PR #2502 changed the logging level of Delete actions from info to debug for the infoblox provider. Looking to change it back so that I have logs on when infoblox deletes things as I had it delete thousands of records by mistake after an upgrade to 0.12.2 from 0.7.6 and had no idea it was happening.

gregsidelinger avatar Sep 06 '22 13:09 gregsidelinger

Yes please! We ran into this issue too and changed it in our fork.

skalpin avatar Sep 07 '22 21:09 skalpin

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 06 '22 22:12 k8s-triage-robot

/lgtm /approve

Raffo avatar Dec 13 '22 09:12 Raffo

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gregsidelinger, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Dec 13 '22 09:12 k8s-ci-robot