external-dns icon indicating copy to clipboard operation
external-dns copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

feat: Add Plural DNS provider

Open davidspek opened this issue 3 years ago • 6 comments

Description This PR adds the Plural DNS provider to external DNS.

Background

Plural is a platform that deploys open source applications on Kubernetes in your cloud using common standards like Helm and Terraform.

The Plural platform provides the following:

  • Dependency management between Terraform/Helm modules, with dependency-aware deployment and upgrades.
  • Authenticated docker registry and chartmuseum proxy per repository.
  • Secret encryption using AES-256 (so you can keep the entire workflow in git).

In addition, Plural also handles:

  • Issuing the certificates.
  • Configuring a DNS service to register fully-qualified domains under onplural.sh to eliminate the hassle of DNS registration for users.
  • Being an OIDC provider to enable zero touch login security for all Plural applications.

Checklist

  • [x] Unit tests updated
  • [x] End user documentation updated

davidspek avatar Aug 01 '22 14:08 davidspek

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: DavidSpek / name: David van der Spek (a0315659896c339c912af5fee6844002bd79ae6a, c905f875e75859b45cd8af1982b7cec1eba05d88)
  • :white_check_mark: login: zreigz / name: Lukasz Zajaczkowski (493ddfc3d5860122471ef73427cecc327501f8a8, 39e7a68c7359f10da9399f5c6d7d62ba587ea9f8)

linux-foundation-easycla[bot] avatar Aug 01 '22 14:08 linux-foundation-easycla[bot]

Welcome @DavidSpek!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Aug 01 '22 14:08 k8s-ci-robot

/assign @njuettner @seanmalloy

davidspek avatar Aug 01 '22 15:08 davidspek

/assign @raffo

davidspek avatar Aug 02 '22 18:08 davidspek

/assign @szuecs

davidspek avatar Aug 09 '22 13:08 davidspek

looks fine to me in general some small things (besides the replace directive which should be clear why and documented). The bigger issue is that we are a bit worried about the number of providers. We will discuss how to proceed in our maintainers meeting. End of September we should have a comment that tells more about how we want to proceed with new providers.

szuecs avatar Aug 24 '22 17:08 szuecs

@szuecs PTAL

zreigz avatar Sep 07 '22 07:09 zreigz

/approve

szuecs avatar Sep 15 '22 16:09 szuecs

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidSpek, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 15 '22 16:09 k8s-ci-robot

/lgtm

szuecs avatar Sep 15 '22 16:09 szuecs