external-dns icon indicating copy to clipboard operation
external-dns copied to clipboard

exoscale provider: migrate to exoscale API v2

Open kobajagi opened this issue 2 years ago • 2 comments

Description

This PR reworks exoscale provider to use new exoscale API v2.

Guide updated and tested.

Checklist

  • [x] Unit tests updated
  • [x] End user documentation updated

kobajagi avatar Jul 28 '22 12:07 kobajagi

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kobajagi Once this PR has been reviewed and has the lgtm label, please assign raffo for approval by writing /assign @raffo in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 28 '22 12:07 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 26 '22 12:12 k8s-triage-robot

/remove-lifecycle stale

kobajagi avatar Dec 27 '22 10:12 kobajagi

@Raffo @njuettner @seanmalloy @szuecs Anything i can do to help with merging this?

kobajagi avatar Apr 12 '23 10:04 kobajagi

@Raffo @njuettner @seanmalloy @szuecs Anything i can do to help with merging this?

This PR is 1 year old and we are about to decommission our API V1, effectively breaking this feature in its current state.

Anything we can do to help moving it forward ?

llambiel avatar Jun 01 '23 12:06 llambiel

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kobajagi, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 14 '23 07:06 k8s-ci-robot

Rebased the branch. Let me know if there is anything else I should do.

kobajagi avatar Jun 15 '23 09:06 kobajagi

I cannot rebase my PR due to #3789

kobajagi avatar Jul 17 '23 13:07 kobajagi

#3789 is fixed

johngmyers avatar Aug 12 '23 18:08 johngmyers

Thanks @johngmyers PR is rebased, @szuecs let me know when this can be merged.

kobajagi avatar Aug 14 '23 10:08 kobajagi

/label tide/merge-method-squash

johngmyers avatar Aug 14 '23 14:08 johngmyers

/lgtm

johngmyers avatar Aug 14 '23 14:08 johngmyers