Add Civo DNS as a new provider

[alejandrojnm]

Description Request to add Civo as a new provider for external-dns

Checklist

• [ x] Unit tests updated
• [ x] End user documentation updated

[alejandrojnm]

/assign @seanmalloy

[stevehipwell]

@alejandrojnm it looks like you've got a partial rebase/merge artefact in Chart.yaml which you might want to clean up.

[alejandrojnm]

@stevehipwell fixed, sorry for that

[stevehipwell]

@alejandrojnm thanks for fixing that. It also looks like you've got the same problem in go.mod.

[alejandrojnm]

@stevehipwell fixed

[alejandrojnm]

@stevehipwell I need to do something else ??

[stevehipwell]

@njuettner could you review this?

[alejandrojnm]

Hi, @stevehipwell @njuettner any update on this?

[alejandrojnm]

Hi @stevehipwell @njuettner ???

[alejandrojnm]

Hi, @stevehipwell @njuettner any update on this?

[stevehipwell]

@alejandrojnm the maintainers who need to look at this PR are currently unavailable.

[alejandrojnm]

Hi, @stevehipwell Thanks Is there any estimated time ??

[stevehipwell]

@alejandrojnm potentially a couple of weeks but I guess it's a moving target.

[drzewo]

Can we get it merged finally, pretty please with sugar on top?

[njuettner]

@drzewo do you mind resolving the conflicts first= I'm happy to review your code

[alejandrojnm]

@drzewo @njuettner I made the rebase from master, if need anything else let me know

[gerhard]

+1

I was missing this as I was preparing for https://kubehuddle.com/2022/#speaker-gerhard-lazu & ended up hand-rolling my own solution. I look forward to using this part of external-dns. Thank you @alejandrojnm for opening this PR!

[alejandrojnm]

Hi, @drzewo @njuettner any update on this ??

[drzewo]

@alejandrojnm, I'm just a passenger waiting for the train (this feature) to arrive. Maybe @njuettner can do something about proceeding this PR past some missing workflow approvals?

[gerhard]

FWIW: https://youtu.be/cdEfbrzRuoc?t=4999

[Raffo]

@alejandrojnm thanks for the updates. There are currently issues with code in civo.go not being gofmt'd. There are also still portions of code that are not covered by tests. Do you think you'll be able to add coverage for those as well?

[alejandrojnm]

Hi @Raffo let me know if is ok in this way

[Raffo]

@alejandrojnm I still see that in submitChanges we are not testing the UpdateDNSRecord and DeleteDNSRecord path. Is this intended or was it just forgotten?

[alejandrojnm]

I will check that right now

[alejandrojnm]

@Raffo ready for review

[Raffo]

@alejandrojnm tests are failing.

[alejandrojnm]

I'm looking, but i run locally and work

Running tool: /usr/local/go/bin/go test -timeout 30s -run ^TestCivoProviderRecords$ sigs.k8s.io/external-dns/provider/civo

=== RUN   TestCivoProviderRecords
--- PASS: TestCivoProviderRecords (0.00s)
PASS
ok      sigs.k8s.io/external-dns/provider/civo

[Raffo]

/approve /lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alejandrojnm, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [Raffo]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment