external-dns
external-dns copied to clipboard
Set logformat before logging config
Description
Google Cloud Logging (AKA Stackdriver Logs) interprets the default
logrus log format as "error" severity even when level=info
is
present in the log output: ensure that the normal startup log
is not parsed as an error by setting the JSON formatter first.
Checklist
- [X] Unit tests updated
- [X] End user documentation updated
Signed-off-by: Nathan J Mehl [email protected]
Welcome @n-oden!
It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
/assign @raffo
/lgtm /assign @Raffo @njuettner
@Raffo @seanmalloy ping? :)
Hey folks, it's been a while here. This is a very small PR -- any chance of getting it merged?
@Raffo @JAORMX @seanmalloy @njuettner ping? :)
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JAORMX, n-oden, Raffo
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [Raffo]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Thanks!