external-dns icon indicating copy to clipboard operation
external-dns copied to clipboard
verified publisher icon kubernetes-sigs

support ExternalID in AWS Provider when assuming a role

Open PG2000 opened this issue 3 years ago • 5 comments

Description

Support ExternalID in AWS Provider when assuming a role.

This is a follow up for the pull request which is closed. Thanks for the work of @dylwylie which i just copy & pasted

Checklist

  • [x] Unit tests updated
  • [ ] End user documentation updated

PG2000 avatar Jun 15 '22 15:06 PG2000

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: PG2000 / name: pg2000 (2a1b79ec108d1c98f97c2d11c1377db0dbbeace1)

linux-foundation-easycla[bot] avatar Jun 15 '22 15:06 linux-foundation-easycla[bot]

/assign @njuettner

PG2000 avatar Jun 17 '22 08:06 PG2000

@seh can we proceeed with this PR?

PG2000 avatar Jul 26 '22 11:07 PG2000

@njuettner can we proceed with this?

PG2000 avatar Aug 05 '22 09:08 PG2000

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner, PG2000, seh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 19 '22 15:08 k8s-ci-robot