external-dns
external-dns copied to clipboard
kubernetes-sigs
Use HasPrefix to check for ownerID
Description
Fix for https://github.com/kubernetes-sigs/external-dns/issues/2706 using HasPrefix to check for owner ship.
Fixes #2706
Checklist
- [x] Unit tests updated
- [x] End user documentation updated
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: sepulworld / name: Zane Williamson (0e7da0e9bf766c8f23731825986e0e0c370e1ff6)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @sepulworld!
It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: sepulworld
To complete the pull request process, please assign njuettner after the PR has been reviewed.
You can assign the PR to them by writing /assign @njuettner in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Great find 👍
I wasn't aware that Istio will add additional data to Service Description
I think it's worth to cover with additional test case in TestAWSSDProvider_DeleteService
Great find 👍 I wasn't aware that Istio will add additional data to Service Description I think it's worth to cover with additional test case in
TestAWSSDProvider_DeleteService
Good call. Added test!
@seanmalloy @njuettner have some time to take a look at this fix? It addresses cleanup issues with Istio based resources. Test added and passing 👍
Hey Team, we would like to implement this in our environment to support our ephemeral clusters.
Hey Team, we would like to implement this in our environment to support our ephemeral clusters.
yes, this fix will get proper cleanup working