external-dns icon indicating copy to clipboard operation
external-dns copied to clipboard

Add maintainers for Infoblox provider

Open ranjishmp opened this issue 2 years ago • 16 comments

Hi,

@Raffo @njuettner @seanmalloy

I am Ranjish, Engineering Manager from Infoblox taking care of Cloud initiatives. We have few customers who are using ExternalDNS plugin to connect with Infoblox. Being Infoblox provider is in alpha state, we would like to take to stable state after through validation. We are also looking for some enhancements which our customers are looking for. So it will great if we get the maintainer access

ranjishmp skudriavtsev anagha-infoblox

Thanks, Ranjish

ranjishmp avatar Mar 30 '22 14:03 ranjishmp

@ranjishmp thanks for reaching out. The first step is to get kubernetes-sigs org membership. Here are the requirements for org membership: https://github.com/kubernetes/community/blob/master/community-membership.md#member

From my perspective the simplest way to meet the requirements for org membership would be to submit some PRs to make changes(features or bug fixes) to the external-dns infoblox provider.

I'd be more than happy to be a sponsor for anyone interesting in pursuing org membership. Let me know if you have any questions on the org membership process.

Thanks!

seanmalloy avatar Apr 08 '22 20:04 seanmalloy

@ranjishmp Same as Sean says, I’m happy to sponsor this. Feel free to send me PRs to review so that we can get you the minimal amount of work to support a case to join the org.

Raffo avatar Apr 14 '22 12:04 Raffo

Thanks @Raffo and @seanmalloy

Sergey (skudriavtsev) will be the main contributor from Infoblox side towards this plugin

He already raised a PR (https://github.com/kubernetes-sigs/external-dns/pull/2670) which is under your review. He will soon raise one more PR for adding certificate based authentication

So it will be good if you can consider him as a maintainer, when you guys feel comfortable

We are also in the process of validating Infoblox provider part from our side. Hope this will help us to take it to beta and then to stable state.

ranjishmp avatar Apr 18 '22 11:04 ranjishmp

@sagor999 Are you still interested in helping maintaining the infoblox provider? I remember we chatter about it a few months ago and I never followed up adding you to the owners.

Raffo avatar Apr 19 '22 08:04 Raffo

@ranjishmp I prepared https://github.com/kubernetes-sigs/external-dns/pull/2713 , which we will be able to merge once we have enough PRs merged from @skudriavtsev and the membership to the org approved.

Raffo avatar Apr 19 '22 08:04 Raffo

@Raffo Thank you. As I mentioned @skudriavtsev is getting ready with his second PR. We will have more PRs once our QA team start validating the plugin.

ranjishmp avatar Apr 19 '22 08:04 ranjishmp

@Raffo I have changed jobs and no longer have access to infoblox setup. So do not add me as a maintainer. But thanks for reaching out!

sagor999 avatar Apr 19 '22 21:04 sagor999

@sagor999 thanks for the answer and best wishes for the new job!

Raffo avatar Apr 20 '22 18:04 Raffo

@Raffo @njuettner @seanmalloy

As I mentioned before our QA team started validating Infoblox provider plugin and reported quite some some bugs. How should we take it forward? @skudriavtsev is woking on few them.

ranjishmp avatar Apr 28 '22 14:04 ranjishmp

@ranjishmp i think I can work to get the membership approved and then you can be free to work on fixing and reviewing those. I will need at the minimum next week as one of the other maintainers that can help me is out of office.

Raffo avatar Apr 28 '22 19:04 Raffo

@ranjishmp https://github.com/kubernetes-sigs/external-dns/pull/2755 was approved, do you have any other PR that you want to get in to add yourself as maintainers of the provider?

Raffo avatar May 25 '22 08:05 Raffo

@Raffo cc @skudriavtsev Yes, we have few more which are under internal testing now. Will raise them soon

ranjishmp avatar May 25 '22 08:05 ranjishmp

Hi @Raffo cc @skudriavtsev

We created this PR and is pending for review - https://github.com/kubernetes-sigs/external-dns/pull/2841

This PR contains support for certificate based authentication and bugfixes

ranjishmp avatar Jun 27 '22 05:06 ranjishmp

Hi,

@Raffo @njuettner @seanmalloy

Any update on when we can get the maintainer access ? There are few PRs we raised which address good amount of issues that we identified during our internal testing. Also added the capability for certificate based authentication

I can see the status for @Raffo as taking a break from opensource. So anyone else can help here ?

ranjishmp avatar Jul 27 '22 14:07 ranjishmp

Hi,

@Raffo @njuettner @seanmalloy

Any update on when we can get the maintainer access ? There are few PRs we raised which address good amount of issues that we identified during our internal testing. Also added the capability for certificate based authentication

I can see the status for @Raffo as taking a break from opensource. So anyone else can help here ?

I'll try to review #2841 soon. I think once that gets merged we should be able to add you to the kubernetes-sigs org.

seanmalloy avatar Jul 27 '22 22:07 seanmalloy

Hi @seanmalloy

You got a chance to review the PR - https://github.com/kubernetes-sigs/external-dns/pull/2841?

ranjishmp avatar Aug 03 '22 10:08 ranjishmp

Hi,

@seanmalloy @Raffo @njuettner

Can you please review the PR - https://github.com/kubernetes-sigs/external-dns/pull/2841?

It will be really helpful for us if we can get the maintainer access.

ranjishmp avatar Aug 22 '22 06:08 ranjishmp

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 20 '22 07:11 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Dec 20 '22 07:12 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Jan 19 '23 08:01 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 19 '23 08:01 k8s-ci-robot