Add the provider for the Tencent Cloud.

[Hyzhou]

Signed-off-by: misakazhou [email protected]

Description

Add the provider for tencent cloud. PrivateDNS service provides intranet DNS resolution. DNSPod service provides internet DNS resolution. Unit tests and document is updated for the tencent cloud provider.

Any issue about the tencent cloud provider can ask @Hyzhou for help and upgrade.

Fixes #ISSUE

Checklist

• [x] Unit tests updated
• [x] End user documentation updated

[k8s-ci-robot]

Welcome @Hyzhou!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[Hyzhou]

@Raffo Would you like to review this PR. Thank you.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[lostz]

I need it so much。

[Hyzhou]

I need it so much。

you can use it now. https://cloud.tencent.com/document/product/457/72679

[lostz]

I need it so much。

you can use it now. https://cloud.tencent.com/document/product/457/72679

thx

[ysicing]

@Hyzhou only support Tencent Cloud(TKE)?

[Hyzhou]

@Hyzhou only support Tencent Cloud(TKE)?

It is a driver support for Tencent Cloud, and test in TKE Clusters. But if you build an kubernetes cluster in Tencent Cloud by your self. I think this driver also work too.

[ysicing]

@Hyzhou example, I want to support DNSPod in EKS(Other Cloud K8s) Clusters, this driver maybe not work.

[Hyzhou]

/sig cloud-provider

[Hyzhou]

@Raffo @njuettner @seanmalloy Would you like to review this PR. Thank you.

[ysicing]

/assign @szuecs

[szuecs]

/remove-lifecycle rotten

[szuecs]

/assign @Raffo

[szuecs]

@Raffo to run the tests looks fine to me

[Raffo]

I approved tests to run, deferring to @szuecs for the final review and call on merge.

[Raffo]

I see this in the CI build:

sh -s -- -b $(go env GOPATH)/bin v1.45.2
golangci/golangci-lint info checking GitHub for tag 'v1.4[5](https://github.com/kubernetes-sigs/external-dns/actions/runs/3031914931/jobs/4935438158#step:6:6).2'
golangci/golangci-lint info found version: 1.45.2 for v1.45.2/linux/amd[6](https://github.com/kubernetes-sigs/external-dns/actions/runs/3031914931/jobs/4935438158#step:6:7)4
golangci/golangci-lint info installed /home/runner/go/bin/golangci-lint
>> checking license header
license header checking failed:
./provider/tencentcloud/privatedns.go
./provider/tencentcloud/dnspod.go
./provider/tencentcloud/tencent_cloud_test.go
make: *** [Makefile:5[8](https://github.com/kubernetes-sigs/external-dns/actions/runs/3031914931/jobs/4935438158#step:6:9): licensecheck] Error 1
./provider/tencentcloud/cloudapi/readonlyapi.go
./provider/tencentcloud/cloudapi/mockapi.go
./provider/tencentcloud/cloudapi/clientset.go
./provider/tencentcloud/cloudapi/api.go
./provider/tencentcloud/cloudapi/tencentapi.go
./provider/tencentcloud/tencent_cloud.go
Error: Process completed with exit code 2.

there's also a conflict with the go.mod now. Can you please fix that @Hyzhou ?

[Hyzhou]

I see this in the CI build:

sh -s -- -b $(go env GOPATH)/bin v1.45.2
golangci/golangci-lint info checking GitHub for tag 'v1.4[5](https://github.com/kubernetes-sigs/external-dns/actions/runs/3031914931/jobs/4935438158#step:6:6).2'
golangci/golangci-lint info found version: 1.45.2 for v1.45.2/linux/amd[6](https://github.com/kubernetes-sigs/external-dns/actions/runs/3031914931/jobs/4935438158#step:6:7)4
golangci/golangci-lint info installed /home/runner/go/bin/golangci-lint
>> checking license header
license header checking failed:
./provider/tencentcloud/privatedns.go
./provider/tencentcloud/dnspod.go
./provider/tencentcloud/tencent_cloud_test.go
make: *** [Makefile:5[8](https://github.com/kubernetes-sigs/external-dns/actions/runs/3031914931/jobs/4935438158#step:6:9): licensecheck] Error 1
./provider/tencentcloud/cloudapi/readonlyapi.go
./provider/tencentcloud/cloudapi/mockapi.go
./provider/tencentcloud/cloudapi/clientset.go
./provider/tencentcloud/cloudapi/api.go
./provider/tencentcloud/cloudapi/tencentapi.go
./provider/tencentcloud/tencent_cloud.go
Error: Process completed with exit code 2.

there's also a conflict with the go.mod now. Can you please fix that @Hyzhou ?

I get it

[Hyzhou]

I see this in the CI build:

sh -s -- -b $(go env GOPATH)/bin v1.45.2
golangci/golangci-lint info checking GitHub for tag 'v1.4[5](https://github.com/kubernetes-sigs/external-dns/actions/runs/3031914931/jobs/4935438158#step:6:6).2'
golangci/golangci-lint info found version: 1.45.2 for v1.45.2/linux/amd[6](https://github.com/kubernetes-sigs/external-dns/actions/runs/3031914931/jobs/4935438158#step:6:7)4
golangci/golangci-lint info installed /home/runner/go/bin/golangci-lint
>> checking license header
license header checking failed:
./provider/tencentcloud/privatedns.go
./provider/tencentcloud/dnspod.go
./provider/tencentcloud/tencent_cloud_test.go
make: *** [Makefile:5[8](https://github.com/kubernetes-sigs/external-dns/actions/runs/3031914931/jobs/4935438158#step:6:9): licensecheck] Error 1
./provider/tencentcloud/cloudapi/readonlyapi.go
./provider/tencentcloud/cloudapi/mockapi.go
./provider/tencentcloud/cloudapi/clientset.go
./provider/tencentcloud/cloudapi/api.go
./provider/tencentcloud/cloudapi/tencentapi.go
./provider/tencentcloud/tencent_cloud.go
Error: Process completed with exit code 2.

there's also a conflict with the go.mod now. Can you please fix that @Hyzhou ?

I already add the lisence header. and rebase the code

[Raffo]

Approved CI again.

[Hyzhou]

Approved CI again.

Sorry, I will run it local.

[szuecs]

/approve /lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Hyzhou, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [szuecs]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment