external-dns
external-dns copied to clipboard
kubernetes-sigs
Support Istio when used with an Ingress resource
What would you like to be added:
When using Istio, it is possible to use this with regular Ingress resources, either via annotation or an IngressClass. However Istio doesn't update the Ingress with the LoadBalancer details. Therefore external-dns does not update the DNS of the ingress.
Why is this needed:
This is really useful when using helm charts that come preconfigured with an ingress. A user can add the appropriate IngressClass or annotation via the values.yaml without having to build a custom VirtualService resource.
This has been previously reported https://github.com/kubernetes-sigs/external-dns/issues/1871
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle stale - Mark this issue or PR as rotten with
/lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle stale - Mark this issue or PR as rotten with
/lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
@nickperkins
I had the same issue yesterday - here's what I did (minimally) to fix it
kubectl create namespace istio-system
helm install istio-base istio/base -n istio-system
# Install istiod. Since the official documentation installs istio ingress gateway to istio-ingress, we need to set
# this environment variable so that the status update can find correct ingress
cat <<EOF > istiod-values.yaml
pilot:
env:
K8S_INGRESS_NS: "istio-ingress"
EOF
helm install istiod istio/istiod -n istio-system -f istiod-values.yaml --wait
kubectl create namespace istio-ingress
kubectl label namespace istio-ingress istio-injection=enabled
# The release name must be istio-ingressgateway, so that the correct label istio=ingressgateway can be set
helm install istio-ingressgateway istio/gateway -n istio-ingress --wait
Reasons:
In istio/pilot/pkg/config/kube/ingressv1/status.go, they gets the ingress address by looking for Istio service in ${ingressNamespace} that has name ${meshConfig.ingressService} (defaults to istio-ingressgateway), and has the selector istio=${meshConfig.ingressSelector} (defaults to ingressgateway)
The ingressNamespace is the value of K8S_INGRESS_NS environment variable, or istio-system (hard-coded). Because the official installation installs istio/gateway to istio-ingress namespace, we need to set the K8S_INGRESS_NS variable
The istio/gateway helm chart set the label istio = helm release name, minus the istio-. So the default installation will set istio=ingress, and not what the status.go is looking for. We need to either set the label in helm value, or set the name to istio-ingressgateway so that the label is correct.
Hope this help
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Reopen this issue with
/reopen - Mark this issue as fresh with
/remove-lifecycle rotten - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close not-planned
@k8s-triage-robot: Closing this issue, marking it as "Not Planned".
In response to this:
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied- After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied- After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closedYou can:
- Reopen this issue with
/reopen- Mark this issue as fresh with
/remove-lifecycle rotten- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close not-planned
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
