external-dns icon indicating copy to clipboard operation
external-dns copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Add DNSMadeEasy Provider

Open bbetter173 opened this issue 3 years ago • 7 comments

Description

This adds support for the DNSMadeEasy API using their Go Client

I have this deployed to our internal development clusters, and am happy to maintain the provider - although my Go skills are somewhat rudimentary at this point.

Fixes #265

Checklist

  • [x] Unit tests updated
  • [x] End user documentation updated

bbetter173 avatar Feb 09 '22 08:02 bbetter173

CLA Signed

The committers are authorized under a signed CLA.

  • :white_check_mark: SwitchTV-BenBettridge (09066a4a5f3bf1aa7834c54309b0f79286222f2e)

linux-foundation-easycla[bot] avatar Feb 09 '22 08:02 linux-foundation-easycla[bot]

Welcome @HeWhoWas!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Feb 09 '22 08:02 k8s-ci-robot

@njuettner @seanmalloy - Sorry to push this along, but what's the best way to get this looked at? I've been using it in our non-production environments for the past 4 weeks without issues.

bbetter173 avatar Mar 07 '22 22:03 bbetter173

We're now using this in production, after ~3 months of no issues while testing.

bbetter173 avatar May 16 '22 05:05 bbetter173

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bbetter173 Once this PR has been reviewed and has the lgtm label, please assign raffo for approval by writing /assign @raffo in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 20 '22 00:07 k8s-ci-robot

@bbetter173: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 20 '22 17:08 k8s-ci-robot

Thanks for this PR! Any chance to do a rebase?

wvengen avatar Sep 13 '22 05:09 wvengen

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 12 '22 06:12 k8s-triage-robot

Sorry for the delays, I've rebased this off latest master.

bbetter173 avatar Dec 13 '22 01:12 bbetter173

@bbetter173 Looking for this support! :) Can you fix the conflit?

gilfrade avatar Jan 23 '23 14:01 gilfrade

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Feb 22 '23 15:02 k8s-triage-robot

I'm happy to rebase it, but at this point the PR has been open for over a year and I would appreciate if it could be reviewed and accepted (or rejected) @seanmalloy @njuettner

bbetter173 avatar Mar 05 '23 06:03 bbetter173

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bbetter173 Once this PR has been reviewed and has the lgtm label, please assign raffo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 05 '23 06:03 k8s-ci-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Apr 10 '23 19:04 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 10 '23 19:04 k8s-ci-robot

/reopen

bbetter173 avatar Apr 10 '23 22:04 bbetter173

@bbetter173: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 10 '23 22:04 k8s-ci-robot

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: SwitchTV-BenBettridge (9dbb4f2aa1e1483278b5f97297ed07c9a768b7af, 9371e6d9103494cdb793738283fb510e2203ae3d, 4ed6ce11210e1443ca86a769c387e363256948df, b51a9760677ebcaff41ef7e6f066043f44325179, cd43c253319ec71011e855639362a805259f1711, 580cfaba8354624e4e0831ca04425582f95f5b5d, abb724121efb2509483115d19f124a700d61ba79, 1c7109af70d2d18cf8ffd4edacd3074e70faa217)
  • :white_check_mark: login: bbetter173 / name: Ben Bettridge (4b60acac0410ea060ffe7e24c89db9bb1a3f00a2)

linux-foundation-easycla[bot] avatar Apr 10 '23 22:04 linux-foundation-easycla[bot]

@njuettner @seanmalloy

Can someone please review this? If I'm missing something, I'd love to know.

bbetter173 avatar Apr 10 '23 22:04 bbetter173

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar May 10 '23 22:05 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar May 10 '23 22:05 k8s-ci-robot