external-dns
external-dns copied to clipboard
kubernetes-sigs
Try #3: Support encrypted DNS txt records
Hi guys,
I found few pull request about txt records encryption (#1314, #1115, #1538), that have conflicts now, or not merged. This PR have latest PR (#1538) with resolved conflicts, hope it will help you to review and merge it.
Fixes #1825 Fixes #854
Checklist
- [x] Unit tests updated
- [x] End user documentation updated
@Raffo, I made some code refactoring, fixed error handling, and crypto functions logic little bit, do you have any other comments?
Anything missing in this PR beside conflicts? I am really interested in this new feature. 😄
I fixed conflicts with master, do It need more changes for be merged, @Raffo?
@Raffo Sorry for tagging you but it seems you need to approve this change. Is there any way you can look into this? We would like to use the txt-registry but don't want to expose any more information to the outside world.
Any reason why this PR not merged yet? It is a very good new feature to not leak any data about your cluster
@Raffo @njuettner Can we help in anything to merge this PR ? It fixes a huge security leak I think. Thanks
@vsychov could you please change request change to review request? maybe this is the only issue here.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle stale - Mark this issue or PR as rotten with
/lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
We still very much want this feature and it is already a PR, so please /remove-lifecycle stale ?
@sheerun @seanmalloy @njuettner @vinny-sabatini Hi guys, any chance that it will be reviewed and merged?
@sheerun @seanmalloy @njuettner @vinny-sabatini Hi guys, any chance that it will be reviewed and merged?
I am really look to see this for months, seriously consider a fork because of this.
We already did a fork :(
@SCLogo I don't suppose you could share a link? It doesn't appear to be on your profile
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle stale - Mark this issue or PR as rotten with
/lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
We already did a fork :(
@SCLogo I don't suppose you could share a link? It doesn't appear to be on your profile
sorry, it is in our private repo :(
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: vsychov
Once this PR has been reviewed and has the lgtm label, please ask for approval from raffo by writing /assign @raffo in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@vsychov: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle stale - Mark this issue or PR as rotten with
/lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
/remove-lifecycle stale
(I understand that everybody is busy, but this was created, then reviewed, improved but now: total silence, why?)
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
So strange that there is ZERO response on this completed feature.
/remove-lifecycle stale
@vsychov sorry that we are so unresponsive. There are too many PRs and issues to respond to, but I try to get something done. PR looks fine from my side, besides the panic I commented. If this is a severe issue, which I don't think it is you should rather log.Fatal then panic, because there is no helpful context that the panic provides in this case.
Another thing that I miss is end-user documentation. Every feature comes with tests and documentation, otherwise no merge.