etcdadm icon indicating copy to clipboard operation
etcdadm copied to clipboard

`etcd-manager` default control store path

Open duxing opened this issue 2 years ago • 1 comments

A question for legacy etcd-manager:

Not the most exciting topic but I can't find a better place for this question (etcd-manager has been archived in favor of this project)

I'm stuck on this old version(3.0.20190930) of etcd-manager and noticed the same behavior on the latest version of etcd-manager too:

the control store is reusing the path for backup (reference). is this desired?

the data from the control store are being used for both controller and backupcontroller. for example, control store contains data to see if a cluster is new (reference)

with the current set up, if we specify a S3 bucket for backup, e.g. s3://foobar, the object hierarchy will look like this:

...
s3://foobar/backup/etcd/main/control/
s3://foobar/backup/etcd/main/control/etcd-cluster-created
s3://foobar/backup/etcd/main/control/etcd-cluster-spec
s3://foobar/backup/etcd/main/2022-01-01T00:00:00Z-123456/
...

where to me what would make more sense would be:

...
s3://foobar/etcd/main/control/
s3://foobar/etcd/main/control/etcd-cluster-created
s3://foobar/backup/etcd/main/control/etcd-cluster-spec
s3://foobar/backup/etcd/main/2022-01-01T00:00:00Z-123456/
...

so that backup dir will contain backup data only, preventing accidentally deleting the control files

duxing avatar Aug 03 '22 22:08 duxing