e2e-framework
e2e-framework copied to clipboard
Skip only features that don't match the criteria
What type of PR is this?
/kind bug /kind regression
What this PR does / why we need it:
We only skip the Feature
and not the whole test (ie.: All Features
in a test Env
, if 1 Feature
fails to match the criteria).)
Just use t.Log
+ return ctx
instead of t.Skipf
:
- Problems with:
t.Skipf
- Skips the whole test => which will skip all other
Features
without checkin if they match the criteria. - Minor mistake:
t.Skipf
should be used if a template is used, but that is not the case here 🙃
- Skips the whole test => which will skip all other
Which issue(s) this PR fixes:
Fixes https://github.com/kubernetes-sigs/e2e-framework/issues/426
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., Usage docs, etc.: