e2e-framework icon indicating copy to clipboard operation
e2e-framework copied to clipboard

initialize k8s client access appropriately when a cluster exists

Open sanposhiho opened this issue 1 year ago • 6 comments
trafficstars

What type of PR is this?

/kind bug

What this PR does / why we need it:

ssia. Currently, when a cluster already exists, initKubernetesAccessClients won't be run. initKubernetesAccessClients is mandatory to be run to make *cluster return KubernetesRestConfig, and consequently now KubernetesRestConfig always results in nil in such case.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix a bug which both kwok and kind providers don't work expectedly when a cluster already exists.

Additional documentation e.g., Usage docs, etc.:


sanposhiho avatar Apr 29 '24 13:04 sanposhiho

/retest

sanposhiho avatar Apr 29 '24 14:04 sanposhiho

@sanposhiho thanks for the PR.. Seems like the same bug exists in the kind provider as well . Would you mind taking care of that as well?

harshanarayana avatar Apr 29 '24 18:04 harshanarayana

@harshanarayana Done.

sanposhiho avatar May 01 '24 07:05 sanposhiho

Thanks very much @sanposhiho

harshanarayana avatar May 01 '24 07:05 harshanarayana

/retest

sanposhiho avatar May 01 '24 08:05 sanposhiho

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanposhiho, vladimirvivien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 08 '24 14:05 k8s-ci-robot