e2e-framework
e2e-framework copied to clipboard
initialize k8s client access appropriately when a cluster exists
What type of PR is this?
/kind bug
What this PR does / why we need it:
ssia.
Currently, when a cluster already exists, initKubernetesAccessClients won't be run.
initKubernetesAccessClients is mandatory to be run to make *cluster return KubernetesRestConfig, and consequently now KubernetesRestConfig always results in nil in such case.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Fix a bug which both kwok and kind providers don't work expectedly when a cluster already exists.
Additional documentation e.g., Usage docs, etc.:
/retest
@sanposhiho thanks for the PR.. Seems like the same bug exists in the kind provider as well . Would you mind taking care of that as well?
@harshanarayana Done.
Thanks very much @sanposhiho
/retest
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sanposhiho, vladimirvivien
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [vladimirvivien]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment