e2e-framework icon indicating copy to clipboard operation
e2e-framework copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

use longer time if deadline is set

Open sivchari opened this issue 1 year ago • 8 comments
trafficstars

What type of PR is this?

/kind feature

What this PR does / why we need it:

If the context deadline is set and the time is longer than default wait time, deadline time is preferred.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., Usage docs, etc.:

sivchari avatar Feb 06 '24 14:02 sivchari

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sivchari Once this PR has been reviewed and has the lgtm label, please assign shwethakumbla for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 06 '24 14:02 k8s-ci-robot

Hi @sivchari. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 06 '24 14:02 k8s-ci-robot

/ok-to-test

harshanarayana avatar Feb 19 '24 06:02 harshanarayana

+1 to what @vladimirvivien mentioned. Guess this can be a general thing across each providers ?

harshanarayana avatar Feb 26 '24 10:02 harshanarayana

Kind has --wait flag, but it's not used in cluster provider. If we'll use it, we should new parameter to wait. Should I change it ?

sivchari avatar Feb 26 '24 11:02 sivchari

@sivchari (apologies for late reply) How is the Duration value passed in to Kwok as a provider ? We should use the same mechanism to pass it to kind if possible. If a flag is needed, we can explore that.

vladimirvivien avatar Apr 08 '24 15:04 vladimirvivien

KWOK has already had waitDruration in struct. So if Kind also has wautDuration in Cluster, we can control the duration time when to wait, can't it ?

sivchari avatar May 01 '24 05:05 sivchari

@sivchari yes, but I am not sure if that is already built into kind (which would make it easier to implement).

vladimirvivien avatar May 08 '24 14:05 vladimirvivien

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 06 '24 14:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Sep 05 '24 15:09 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Oct 05 '24 15:10 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Oct 05 '24 15:10 k8s-ci-robot