e2e-framework icon indicating copy to clipboard operation
e2e-framework copied to clipboard

Add exec function to run commands inside pod

Open matrus2 opened this issue 2 years ago • 8 comments

Hi,

It might be useful to have possibility to execute a command inside a pod by a single build-in function during for instance network testing.

Thanks

matrus2 avatar Sep 20 '22 16:09 matrus2

Hi @matrus2. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 20 '22 16:09 k8s-ci-robot

/ok-to-test

ShwethaKumbla avatar Sep 21 '22 14:09 ShwethaKumbla

@matrus2 Thanks for the PR.

Could you please resolve the failed tests?

ShwethaKumbla avatar Sep 22 '22 10:09 ShwethaKumbla

/retest

matrus2 avatar Sep 22 '22 13:09 matrus2

/retest

matrus2 avatar Sep 22 '22 13:09 matrus2

I notice there is a failing test not related to the change I introduced, I will look if this can be improved.

matrus2 avatar Sep 22 '22 13:09 matrus2

/cc @ShwethaKumbla

matrus2 avatar Sep 30 '22 09:09 matrus2

/cc @vladimirvivien Would love to see this functionality in place. May I ask you to have a quick look?

matrus2 avatar Oct 27 '22 14:10 matrus2

@matrus2 please take a look.

vladimirvivien avatar Nov 03 '22 01:11 vladimirvivien

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: matrus2

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 08 '22 08:11 k8s-ci-robot