dra-example-driver icon indicating copy to clipboard operation
dra-example-driver copied to clipboard

Add mechanism to pass device attributes

Open dharmjit opened this issue 2 months ago • 3 comments

This PR adds a mechanism to pass device attributes to emulate the real devices in local test setups.

  • Add --device-attributes CLI flag and DEVICE_ATTRIBUTES env var
  • Implement automatic type detection for int, bool, version, string values
  • Add Helm template support for device attributes configuration

dharmjit avatar Sep 29 '25 13:09 dharmjit

Welcome @dharmjit!

It looks like this is your first PR to kubernetes-sigs/dra-example-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/dra-example-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Sep 29 '25 13:09 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dharmjit Once this PR has been reviewed and has the lgtm label, please assign elezar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 29 '25 13:09 k8s-ci-robot

Thanks @nojnhuh for taking a look at the PR, I have resolved your review comments in the subsequent commit. Thanks!

dharmjit avatar Oct 13 '25 11:10 dharmjit