descheduler icon indicating copy to clipboard operation
descheduler copied to clipboard

Upgrade client-go to 0.24

Open fredkan opened this issue 2 years ago • 1 comments

Support Kubernetes 1.24 version environment.

What version of descheduler are you using? 1.24

descheduler version: Latest

fredkan avatar Jun 27 '22 00:06 fredkan

@fredkan the descheduler is built with client-go at 1.24: https://github.com/kubernetes-sigs/descheduler/blob/871a103/go.mod#L12

Are you referring to something else?

damemi avatar Jun 28 '22 12:06 damemi

I noticed kubectl is on an old version (0.20)

This is being upgraded to 0.25 in the 0.25 release

a7i avatar Sep 04 '22 14:09 a7i

I noticed kubectl is on an old version (0.20)

That's a good catch, and I actually don't think we need that dependency on kubectl. The only place it's being used is in an e2e for GetPodQOS() and it's pretty similar to another GetPodQOS() function we copied over.

We should look into dropping that if possible, it's kind of weird to be depending on kubectl

damemi avatar Sep 06 '22 01:09 damemi

Agreed. I took a stab at it here but the builds are broken until 0.25 is merged.

a7i avatar Sep 06 '22 12:09 a7i

fixed in #938 /close

damemi avatar Sep 19 '22 20:09 damemi

@damemi: Closing this issue.

In response to this:

fixed in #938 /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 19 '22 20:09 k8s-ci-robot