Kubernetes 1.25 Release Timeline

[damemi]

From https://github.com/kubernetes/sig-release/blob/master/releases/release-1.25/README.md:

The 1.25 release cycle is as follows:

• Monday 23rd May 2022: Week 1 — Release cycle begins
• Thursday 9th June 2022: Week 3 — Production Readiness Soft Freeze
• 02:00 UTC Friday 17th June 2022 / 18:00 PST Thursday 16th June 2022 : Week 4 — Enhancements Freeze
• Wednesday 27th July 2022: Week 10 — [Release Retrospective][Retrospective Document] part 1
• 01:00 UTC Wednesday 3rd August 2022 / 02:00 BST Wednesday 3rd August 2022 / 18:00 PDT Tuesday 2nd August 2022: Week 11 — Code Freeze
• 01:00 UTC Wednesday 10th August 2022 / 02:00 BST Wednesday 10th August 2022 / 18:00 PDT Tuesday 9th August 2022: Week 12 — Test Freeze
• Tuesday 16th August 2022: Week 13 — Docs must be completed and reviewed
• Tuesday 23rd August 2022: Week 14 — Kubernetes v1.25.0 released
• TBC: Week 16 — [Release Retrospective][Retrospective Document] part 2

---

(Will update with checklist for Descheduler release tasks)

[knelasevero]

templates/podsecuritypolicy.yaml: policy/v1beta1 PodSecurityPolicy is deprecated in v1.21+, unavailable in v1.25+

Helm linting catches this for the templates there. We should stop using PodSecurityPolicy before 1.25 arrives.

[JaneLiuL]

i check Kubernetes 1.25 rc.0 already tag, if no one pick , i will start to work on it :)

[JaneLiuL]

Steps for Descheduler release:

• Bump k8s.io dependencies to rc post code freeze/prior to 1.25 release (ex https://github.com/kubernetes-sigs/descheduler/pull/539) (nice to have)
• Bump k8s.io dependencies to GA 1.25 post release (ex https://github.com/kubernetes-sigs/descheduler/pull/615)
• Add release-1.25 branch tests and update old branch tests in k8s.io/test-infra (https://github.com/kubernetes/test-infra/pull/25833)
• Update version references in docs/readme/compatibility matrix (ex https://github.com/kubernetes-sigs/descheduler/pull/617)
• Tag v0.25 from master
• Update Helm chart (ex https://github.com/kubernetes-sigs/descheduler/pull/709)
• Cut release-1.25 branch
• Promote image from tagged branch commit (ex https://github.com/kubernetes/k8s.io/pull/3344)
• Publish release

[pravarag]

@JaneLiuL @damemi @ingvagabund I can pick up below three tasks:

~~> * Add release-1.25 branch tests and update old branch tests in k8s.io/test-infra~~

• Update version references in docs/readme/compatibility matrix
• Update Helm chart

[damemi]

Thanks @JaneLiuL and @pravarag, yes we should start preparing the 1.25 release with the rc.0 tag bump

[JaneLiuL]

greate~~ i will check is there anyone will pick the rc.0, if no one pick till 2022-8-13, i will start to work on rc-0. :)

[JaneLiuL]

since no one pick rc.0, i would start to work on rc.0 now

[JaneLiuL]

update here. i raise pr, but i finger out k8s 1.25.0-rc.0 have issues with fakeclient evict pod, check function here https://github.com/JaneLiuL/descheduler/blob/master/pkg/descheduler/descheduler_test.go#176 i use fakeclient to evict pod, but the pod number still the same.

[damemi]

Thanks @JaneLiuL, what's the issue you're seeing? Let's continue that discussion in your PR

[pravarag]

I've started working on adding new tests and updating helm chart, will share the PR soon.

[damemi]

Updated the main comment here with a checklist for the pre-release actions

For the next release, I'm thinking of organizing it with a Github project, which basically just gives us a nice sprint board to plan and assign tasks. Thoughts?

[JaneLiuL]

good suggestion !

[eminaktas]

Hi, I don't know if I am late for this but we have a problem with the app version that we discussed before #736. The latest descheduler version is v20220601-descheduler-helm-chart-0.24.1-3-g9bf473b7e in the latest container image descheduler/descheduler:v0.24.1.

Do we need to check before we take the new release?

P.S.: I didn't check the merged PRs between 0.24.1 and master

[damemi]

@eminaktas you're not too late, but could you share where you're seeing that? When I run descheduler version I only see it in the GitVersion:

mikedame ~$ docker run -it k8s.gcr.io/descheduler/descheduler:v0.24.0 descheduler version
Descheduler version {Major:0 Minor:24+ GitVersion:v20220516-v0.24.0-2-geb0be6568 GitBranch: GitSha1: BuildDate:2022-05-16T22:07:44+0000 GoVersion:go1.17.7 Compiler:gc Platform:linux/amd64}

mikedame ~$ docker run -it k8s.gcr.io/descheduler/descheduler:v0.24.1 descheduler version
Descheduler version {Major:0 Minor:24.1 GitVersion:v20220601-descheduler-helm-chart-0.24.1-3-g9bf473b7e GitBranch: GitSha1: BuildDate:2022-06-01T14:26:48+0000 GoVersion:go1.18.2 Compiler:gc Platform:linux/amd64}

imo this is okay, but maybe we can work out a way to parse it better. I think the important part is that the major and minor versions are right

[damemi]

At this point, I think we are all done with the pre-release steps (except for the helm chart update in https://github.com/kubernetes-sigs/descheduler/pull/936, which has to wait until after we tag the release).

I will be OOO tomorrow, and don't think we should push out a release on Friday anyway. So what does everyone think about leaving today and tomorrow for any last-minute code changes and then cut the release on Monday?

[eminaktas]

@eminaktas you're not too late, but could you share where you're seeing that? When I run descheduler version I only see it in the GitVersion:

mikedame ~$ docker run -it k8s.gcr.io/descheduler/descheduler:v0.24.0 descheduler version
Descheduler version {Major:0 Minor:24+ GitVersion:v20220516-v0.24.0-2-geb0be6568 GitBranch: GitSha1: BuildDate:2022-05-16T22:07:44+0000 GoVersion:go1.17.7 Compiler:gc Platform:linux/amd64}

mikedame ~$ docker run -it k8s.gcr.io/descheduler/descheduler:v0.24.1 descheduler version
Descheduler version {Major:0 Minor:24.1 GitVersion:v20220601-descheduler-helm-chart-0.24.1-3-g9bf473b7e GitBranch: GitSha1: BuildDate:2022-06-01T14:26:48+0000 GoVersion:go1.18.2 Compiler:gc Platform:linux/amd64}

imo this is okay, but maybe we can work out a way to parse it better. I think the important part is that the major and minor versions are right

Thank you @damemi.

GitVersion is being used in the Prometheus metrics. This is not critical but we had the correct version with v0.24.0 as you posted above v20220516-v0.24.0-2-geb0be6568. But with v0.24.1, we had version like this v20220601-descheduler-helm-chart-0.24.1-3-g9bf473b7e`.

I can take a look at it if you think it's worth working on. Maybe we can eliminate the human errors here. Also, we should change Prometheus metric label DeschedulerVersion in the code.

https://github.com/kubernetes-sigs/descheduler/blob/2d9143d129036a5aed235c78dd86617b4e457a49/metrics/metrics.go#L46

I think we should show DeschedulerVersion as 0.24.1 ({Major}.{Minor}) and add GitVersion to the label. What do you think?

[damemi]

That sounds good to me, I agree the metric should at least report the major+minor versions. Concatenating them into 1 label is probably good too. Do you think we can still report the git version? Could be useful for development or custom builds.

On Thu, Sep 8, 2022, 3:30 PM Emin AKTAS @.***> wrote:

@eminaktas https://github.com/eminaktas you're not too late, but could you share where you're seeing that? When I run descheduler version I only see it in the GitVersion:

mikedame ~$ docker run -it k8s.gcr.io/descheduler/descheduler:v0.24.0 descheduler version Descheduler version {Major:0 Minor:24+ GitVersion:v20220516-v0.24.0-2-geb0be6568 GitBranch: GitSha1: BuildDate:2022-05-16T22:07:44+0000 GoVersion:go1.17.7 Compiler:gc Platform:linux/amd64}

mikedame ~$ docker run -it k8s.gcr.io/descheduler/descheduler:v0.24.1 descheduler version Descheduler version {Major:0 Minor:24.1 GitVersion:v20220601-descheduler-helm-chart-0.24.1-3-g9bf473b7e GitBranch: GitSha1: BuildDate:2022-06-01T14:26:48+0000 GoVersion:go1.18.2 Compiler:gc Platform:linux/amd64}

imo this is okay, but maybe we can work out a way to parse it better. I think the important part is that the major and minor versions are right

Thank you @damemi https://github.com/damemi.

GitVersion is being used in the Prometheus metrics. This is not critical but we had the correct version with v0.24.0 as you posted above v20220516-v0.24.0-2-geb0be6568. But with v0.24.1, we had version like this v20220601-descheduler-helm-chart-0.24.1-3-g9bf473b7e`.

I can take a look at it if you think it's worth working on. Maybe we can eliminate the human errors here. Also, we should change Prometheus metric label DeschedulerVersion in the code.

https://github.com/kubernetes-sigs/descheduler/blob/2d9143d129036a5aed235c78dd86617b4e457a49/metrics/metrics.go#L46

I think we should show DeschedulerVersion as 0.24.1 ({Major}.{Minor}) and add GitVersion to the label. What do you think?

— Reply to this email directly, view it on GitHub https://github.com/kubernetes-sigs/descheduler/issues/844#issuecomment-1241137686, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOA77P2WRVMACAMPRBP64DV5I5D7ANCNFSM5YGUUVXQ . You are receiving this because you were mentioned.Message ID: @.***>

[eminaktas]

Yes, I agree that we should keep reporting the git version too. I'll have a quick patch for it.

[damemi]

Anything else blocking this release? If not, I'm going to tag the new Git version, merge https://github.com/kubernetes-sigs/descheduler/pull/936, and start the image promotion PRs

@ingvagabund @knelasevero @a7i @JaneLiuL @pravarag

[JaneLiuL]

hi, i don't see any blocking :) please continue

[damemi]

Tag created, helm change merged, image promotion PR created at https://github.com/kubernetes/k8s.io/pull/4213, need approval there

[damemi]

Image promotion is done, helm chart releaser completed successfully, and release published at https://github.com/kubernetes-sigs/descheduler/releases/tag/v0.25.0! Just emailed sig-scheduling to announce it. Thanks everyone for another great release 🎉 /close

[k8s-ci-robot]

@damemi: Closing this issue.

In response to this:

Image promotion is done, helm chart releaser completed successfully, and release published at https://github.com/kubernetes-sigs/descheduler/releases/tag/v0.25.0! Just emailed sig-scheduling to announce it. Thanks everyone for another great release 🎉 /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pravarag]

Image promotion is done, helm chart releaser completed successfully, and release published at https://github.com/kubernetes-sigs/descheduler/releases/tag/v0.25.0! Just emailed sig-scheduling to announce it. Thanks everyone for another great release tada /close

Happy to be a part of one more release 🥂