descheduler
descheduler copied to clipboard
kubernetes-sigs
add strategy defaults and fix nodeFit for node affinity strategy
This adds defaults for strategies. Now each strategy may have different default parameters, if some are omitted from the configmap.
Since the NodeFit parameter was a bool instead of a pointer, it couldn't be detected whether it was being set in the configmap, or not. Hence it is changed to a pointer. If it is not set in the configmap, the default is taken.
Except for node affinity, all other strategies are now having a default of false for an omitted NodeFit parameter, which matches exactly how things have worked.
For the node affinity strategy, the legacy mode of operation has always been what a "true" NodeFit would be. Thus an omitted NodeFit parameter for that strategy is set to true, which matches how node affinity has been working, effectively not evicting anything if the pod doesn't fit into another node.
The change is in how things work when the NodeFit is explicitly set to "false". The hard-coded check for pod fitting any node is removed, and the NodeFit feature has control. NodeFit being false, node affinity strategy will evict the pod regardless of whether there is another node where it would fit.
Fixes #640
Signed-off-by: Ukri Niemimuukko [email protected]
Welcome @uniemimu!
It looks like this is your first PR to kubernetes-sigs/descheduler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/descheduler has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @uniemimu. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign damemi after the PR has been reviewed.
You can assign the PR to them by writing /assign @damemi in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@bart0sh: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/ok-to-test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Nit for self, and for conversation: PodFitsAnyNode has no users anymore if this gets merged. Should it be removed at the same time?
Squashed and cleaned. Sorry for the slipped in hacks in the intermediates.
@uniemimu thanks for keeping the defaulting in mind. As part of moving to the descheduling framework, this becomes part of the core changes in the code base after all plugins are migrated to plugins.
@uniemimu thanks for keeping the defaulting in mind. As part of moving to the descheduling framework, this becomes part of the core changes in the code base after all plugins are migrated to plugins.
Ok please let me know if this is worth rebasing on top of some WIP PR which is considered better off going in first.
@uniemimu: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@uniemimu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-descheduler-test-e2e-k8s-master-1-25 | 5d54ac18e0f1f49b68bb087b5f550d3875b2c9cf | link | true | /test pull-descheduler-test-e2e-k8s-master-1-25 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle stale - Mark this issue or PR as rotten with
/lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
@uniemimu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-descheduler-test-e2e-k8s-master-1-25 | 5d54ac18e0f1f49b68bb087b5f550d3875b2c9cf | link | true | /test pull-descheduler-test-e2e-k8s-master-1-25 |
| pull-descheduler-test-e2e-k8s-master-1-26 | 5d54ac18e0f1f49b68bb087b5f550d3875b2c9cf | link | true | /test pull-descheduler-test-e2e-k8s-master-1-26 |
| pull-descheduler-test-e2e-k8s-master-1-27 | 5d54ac18e0f1f49b68bb087b5f550d3875b2c9cf | link | true | /test pull-descheduler-test-e2e-k8s-master-1-27 |
| pull-descheduler-test-e2e-k8s-master-1-28 | 5d54ac18e0f1f49b68bb087b5f550d3875b2c9cf | link | true | /test pull-descheduler-test-e2e-k8s-master-1-28 |
| pull-descheduler-test-e2e-k8s-master-1-29 | 5d54ac18e0f1f49b68bb087b5f550d3875b2c9cf | link | true | /test pull-descheduler-test-e2e-k8s-master-1-29 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Reopen this PR with
/reopen - Mark this PR as fresh with
/remove-lifecycle rotten - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
@k8s-triage-robot: Closed this PR.
In response to this:
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied- After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied- After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closedYou can:
- Reopen this PR with
/reopen- Mark this PR as fresh with
/remove-lifecycle rotten- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.