custom-metrics-apiserver icon indicating copy to clipboard operation
custom-metrics-apiserver copied to clipboard

Bump the k8s-dependencies group across 1 directory with 8 updates

Open L3n41c opened this issue 4 months ago • 4 comments

PR built on top of #183 to bump the k8s.io/… modules Kubernetes dependencies.

The simple bump of the version wasn’t working because of : https://github.com/kubernetes-sigs/custom-metrics-apiserver/pull/183#issuecomment-2376384883.

The two following commits:

  • https://github.com/kubernetes/apiserver/commit/22612a3528a6ac083dc02bc27aa143c248e0d233#diff-d84eac55294d8f540a660bfcb4043f7c4e1f76c8bccbb91c129e8e4992dbafe7L151-L152
  • https://github.com/kubernetes/apiserver/commit/00857ca9ec84204bf59080cbc04cbf68d3edee7c#diff-d84eac55294d8f540a660bfcb4043f7c4e1f76c8bccbb91c129e8e4992dbafe7L1106

made me think that EffectiveVersion is what replaces the now-removed Version field of the server.Config struct.

L3n41c avatar Oct 14 '24 12:10 L3n41c