custom-metrics-apiserver icon indicating copy to clipboard operation
custom-metrics-apiserver copied to clipboard

resClient.List should add resourceVersion=0 parameter

Open xiaomudk opened this issue 2 years ago • 2 comments

resourceVersion=0 is not specified here, causing apiserver to skip the cache and go directly to etcd to read the data. add resourceVersion=0 parameter, apiserver will read data from the cache, and there is an order of magnitude performance improvement.

xiaomudk avatar Jul 06 '23 18:07 xiaomudk

/triage accepted /assign

logicalhan avatar Jul 13 '23 16:07 logicalhan

I don't think that's something we want to do since it might be hitting stale data from the cache.

dgrisonnet avatar Sep 04 '23 17:09 dgrisonnet

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

k8s-triage-robot avatar Sep 03 '24 17:09 k8s-triage-robot

/close based on https://github.com/kubernetes-sigs/custom-metrics-apiserver/issues/154#issuecomment-1705572167

dashpole avatar Sep 05 '24 16:09 dashpole

@dashpole: Closing this issue.

In response to this:

/close based on https://github.com/kubernetes-sigs/custom-metrics-apiserver/issues/154#issuecomment-1705572167

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Sep 05 '24 16:09 k8s-ci-robot