controller-tools icon indicating copy to clipboard operation
controller-tools copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

:bug: return a bit more verbosy error messages for go-package errors

Open AlmogBaku opened this issue 2 years ago • 4 comments

When having sub-packages, and one of them is out of sync, we might get an error such as:

err: exit status 1: stderr: go: updates to go.mod needed; to update it:
        go mod tidy

Although this error is true, it was a nightmare to debug it and figure out that it was related to a sub-package.

This PR introduces a bit more verbosy error message that can help you to debug the issue:

Error: error in /Users/AlmogBaku/projects/myproject/subpackage: err: exit status 1: stderr: go: updates to go.mod needed; to update it:
        go mod tidy

AlmogBaku avatar Sep 18 '22 12:09 AlmogBaku

might be related to #718

AlmogBaku avatar Sep 18 '22 12:09 AlmogBaku

/assign @mengqiy

AlmogBaku avatar Sep 18 '22 20:09 AlmogBaku

New changes are detected. LGTM label has been removed.

k8s-ci-robot avatar Sep 23 '22 20:09 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AlmogBaku, camilamacedo86 Once this PR has been reviewed and has the lgtm label, please ask for approval from mengqiy by writing /assign @mengqiy in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 23 '22 20:09 k8s-ci-robot

Any updates on when this PR can be merged? It indeed is a nightmare to debug.

deepankarm avatar Nov 08 '22 08:11 deepankarm

The requested changes by @joelanford are addressed so we can :

/lgtm

camilamacedo86 avatar Nov 17 '22 09:11 camilamacedo86

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: AlmogBaku, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 17 '22 09:11 k8s-ci-robot