controller-runtime

controller-runtime copied to clipboard

:sparkles: Use `klog` as the controller-runtime default logger

5

Fixes https://github.com/kubernetes-sigs/kubebuilder/issues/3018 To make the log output consistent with K8s core components (kube-apiserver, kube-controller-manager, etc), and more human readable. Test results: Before this PR, the kubebuilder generated controller-manager log is:...

astraw99

🐛 Inc `Generation` on `fakeClient` `Update`/`Patch`

5

Closes #1857. This applies only to custom resources! The behaviour of the API server regarding generation is polymorphic meaning that any resource type may behave differently. Custom resources have a...

danaradg

:seedling: add preWatch options for leader-elections runnables to reduce failover time when leader changes

5

### What does this do, and why do we need it? As we know leader-elections runnables only have one working instance, when the leader instance changes, the new leader should...

nicktming

Logging the reason for a reconcile

5

Hey there, is there any mechanism to log which event caused a reconcile request, or generally some other tooling to figure this out? We have a controller that owns some...

austince

Similar to the flags for Webhook [Port and Host](https://github.com/kubernetes-sigs/controller-runtime/blob/2f77235e25b1e42d9e4957199f3cd0f2c3fb0d72/pkg/manager/manager.go#L212-L217), we should also expose flags for setting the minimum TLS version as well as the cipher suites to be used when...

srm09

Add a util method to recognize if resource in reconcile loop is being deleted

3

I noticed there is no common method so I see a lot of `if xxx.,metadata.deletionTimestamp...` logic, I thin it would be profitable to add utility method like `isBeingDeleted(object)` to determine...

grzesuav

Me and @pleic have a reconciler that relies on `metadata.UID` being set on the API objects it manages, and soon we'll also need `metadata.CreationTimestamp`. We are writing unit tests that...

matteoolivi

:seedling: Register kubeconfig flag variable via RegisterFlags func

11

There have been reported issues (`flag redefined`) because CR registers the `kubeconfig` flag to the default command line FlagSet via init function. See: * https://github.com/kubernetes-sigs/controller-runtime/issues/1396 * https://github.com/kubernetes-sigs/controller-runtime/issues/878 This PR provides...

johannesfrey

Objects passed to event filter have empty TypeMeta

2

Objects in the event object passed to filters like `Create(e event.CreateEvent) bool` have empty `TypeMeta`. The `TypeMeta` is properly populated when getting objects from the client.

alculquicondor

Currently deleg log sink does not support call depth, this makes it difficult to use with helpers funcs. We could record call depth and apply it when fulfilling the promise.

eddycharly