controller-runtime
controller-runtime copied to clipboard
kubernetes-sigs
⚠️ Remove manager options deprecation
options.AndFrom and options.AndFromOrDie have been deprecated over several releases. This PR will remove them where consumers will have to migrate to their own config solution.
- [x] Remove function
options.AndFrom - [x] Remove function
options.AndFromOrDie
/kind cleanup
:+1: I think we can only remove these functions when we remove sigs.k8s.io/controller-runtime/pkg/config too.
This code ensures that the options work So, IMO it should only be removed when the options be removed and are no longer supported.
The options.AndFrom was loading a config that @inteon agreed that we can only deprecate this if we deprecate the config package.
Do you mean that the options that get merged with the config options shouldn't be removed? This doesn't remove any options.
https://github.com/kubernetes-sigs/controller-runtime/issues/895
👍 I think we can only remove these functions when we remove sigs.k8s.io/controller-runtime/pkg/config too.
Very true, I can delete those as well.
/lgtm PR LGTM, we now just need an approver to agree that we want to remove this deprecated feature already.
LGTM label has been added.
/lgtm PR LGTM, we now just need an approver to agree that we want to remove this deprecated feature already.
Thank you for the review, I know that this has to be coordinated and maybe targeted for v0.18.0.
LGTM label has been added.
/retitle ⚠️ Remove deprecated manager options
The current title sounds to me like we were un-deprecating something, WDYT? /lgtm /approve /hold
In case @vincepri wants to have a look
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alvaroaleman, troy0820
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [alvaroaleman]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@troy0820: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-controller-runtime-apidiff | 66154d374a85819a8c834adea2d805f50d16c950 | link | false | /test pull-controller-runtime-apidiff |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.