controller-runtime icon indicating copy to clipboard operation
controller-runtime copied to clipboard

cannot set syncperiod for CRs and cache independently

Open ggaurav10 opened this issue 2 years ago • 5 comments

In version 0.15.0, the manager.Options.SyncPeriod has been deprecated in favor of manager.Options.Cache.SyncPeriod. The cache.Options.Resync has been effectively removed. Before this release it was possible to set different sync periods for the watched CRs and the cache. The earlier syncPeriod insured against these as mentioned in the comments: image

If we still want to insure against these, do we need to shorten the cache sync period now? would it have larger effect on the apiserver load? If yes, should we introduce cache resync again?

ggaurav10 avatar Dec 12 '23 14:12 ggaurav10

/kind support

troy0820 avatar Dec 12 '23 14:12 troy0820

would it have larger effect on the apiserver load?

I think this depends on what you do in your Reconcile func. The sync itself does not execute a List call against the APIserver (it just enqueues objects that are stored locally)

sbueringer avatar Dec 18 '23 14:12 sbueringer

Before this release it was possible to set different sync periods for the watched CRs and the cache.

Can you please give an example what exactly you did with CR v0.15?

sbueringer avatar Dec 18 '23 14:12 sbueringer

Before this release it was possible to set different sync periods for the watched CRs and the cache.

Can you please give an example what exactly you did with CR v0.15?

we set the syncPeriod to 2 minutes and leave cache.Resync to default (10 hours).

ggaurav10 avatar Dec 18 '23 15:12 ggaurav10

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Mar 17 '24 16:03 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Apr 16 '24 16:04 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar May 16 '24 17:05 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 16 '24 17:05 k8s-ci-robot