controller-runtime icon indicating copy to clipboard operation
controller-runtime copied to clipboard

support configuring `RecoverPanic` globally

Open mars1024 opened this issue 2 years ago • 1 comments

Now RecoverPanic is only a field in controller.Options, if we want to enable this for all controllers, each controller initialization should be modified.

Since GroupKindConcurrency and CacheSyncTimeout can both be set through global v1alpha1.ControllerConfigurationSpec, IMO, RecoverPanic can do the same.

The only left problem is that RecoverPanic is bool type which has no zero-value, so maybe it has to be changed to pointer type, but i'm afraid this will be a break change.

mars1024 avatar Sep 15 '22 09:09 mars1024

/assign

mars1024 avatar Sep 15 '22 09:09 mars1024