controller-runtime icon indicating copy to clipboard operation
controller-runtime copied to clipboard

✨ Support multiple field selectors

Open tamalsaha opened this issue 3 years ago • 6 comments

Signed-off-by: Tamal Saha [email protected]

tamalsaha avatar Mar 11 '22 22:03 tamalsaha

Hi @tamalsaha. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 11 '22 22:03 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tamalsaha To complete the pull request process, please assign mengqiy after the PR has been reviewed. You can assign the PR to them by writing /assign @mengqiy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 11 '22 22:03 k8s-ci-robot

Thanks @FillZpp ! I have added checks for generation. Now, we can be sure that the result for the all indices are for the same object.

tamalsaha avatar Mar 14 '22 21:03 tamalsaha

Hi, there. I wanna add a complicated index into thread safe store. If it will be accepted, it helps here.

Related issues and pr

weilaaa avatar Apr 24 '22 03:04 weilaaa

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 23 '22 04:07 k8s-triage-robot

/remove-lifecycle stale

tamalsaha avatar Aug 01 '22 22:08 tamalsaha

@tamalsaha: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 27 '22 18:10 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 25 '23 19:01 k8s-triage-robot

Closing due to inactivity, @tamalsaha please feel free to reopen once ready

/close

vincepri avatar Feb 16 '23 22:02 vincepri

@vincepri: Closed this PR.

In response to this:

Closing due to inactivity, @tamalsaha please feel free to reopen once ready

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 16 '23 22:02 k8s-ci-robot