controller-runtime icon indicating copy to clipboard operation
controller-runtime copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Ginkgo v2 migration

Open DirectXMan12 opened this issue 4 years ago • 9 comments

Ginkgo has started warning about the Ginkgo v2 upgrade, which deprecates the done argument to tests (the suggestion is to use Eventually and such). We should look at migrating our tests over.

/help

DirectXMan12 avatar Jun 01 '21 17:06 DirectXMan12

@DirectXMan12: This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

Ginkgo has started warning about the Ginkgo v2 upgrade, which deprecates the done argument to tests (the suggestion is to use Eventually and such). We should look at migrating our tests over.

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jun 01 '21 17:06 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 30 '21 18:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Sep 29 '21 18:09 k8s-triage-robot

/remove-lifecycle rotten

palnabarun avatar Oct 06 '21 15:10 palnabarun

/assign

ystkfujii avatar Feb 02 '22 14:02 ystkfujii

/assign

acumino avatar Feb 04 '22 10:02 acumino

/unassign

ystkfujii avatar Feb 08 '22 01:02 ystkfujii

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 09 '22 02:05 k8s-triage-robot

/remove-lifecycle stale

camilamacedo86 avatar May 09 '22 11:05 camilamacedo86