controller-runtime

controller-runtime copied to clipboard

How to use log in my function

5

In the official [example](https://github.com/kubernetes-sigs/controller-runtime/blob/adc9fa96250106ebf0a3c589aa64e085e90870fd/examples/crd/main.go#L46)，set a variable named `log`，and we can use log.Info() or log.Error() later. But now I have multi function, do I have to set log := log.FromContext(ctx) at...

acechef

⚠ cache.BuilderWithOptions inherit options from caller

1

using cache.BuilderWithOptions does not properly inherit all options passed in from the caller: - scheme was overridden instead of merged - selectors were not inherited at all, even if specified...

joelanford

:sparkles: multiNamespaceCache: support custom newCache funcs per namespace

5

This PR adds more flexibility to multi-namespace caches by introducing a new cache builder function (`cache.ByNamespaceBuilder`) that enables callers to specify individual cache builder functions on a per-namespace basis (with...

joelanford

⚠ Migrate to ginkgo v2

5

Revives #1792, thanks to @acumino for all your work on this. Fixes: #1545 Important Note: -> Per node timeout has been removed to prevent the wrongly marking a test as...

schrej

I use the client to delete the job, but the pod is not deleted, I can delete the corresponding pod with `kubectl delete job`

acechef

:warning: kube aware logger which could also work with logger.WithValues

30

Signed-off-by: STRRL This PR could fix https://github.com/kubernetes-sigs/controller-runtime/issues/1290 As [this comment](https://github.com/kubernetes-sigs/controller-runtime/issues/1290#issuecomment-1108577167) says, the latest logr provide `logr.Marshaler`, it could be used instead the current "kube-aware-logger-things" implementation with custom zap encoder

STRRL

✨ logging: allow override default logger for compatibility

6

#1827 introduces `WithLogConstructor` and removed `WithLogger` but in practical it's very hard to use `WithLogConstructor` to inject fields like: - "controller", controllerName - "controllerGroup": gvk.Group - "controllerKind", gvk.Kind This PR...

timonwong

Change the default recorder provider to use events.k8s.io/v1

1

**Description** Controller-runtime uses core.Events: https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/internal/recorder/recorder.go#L113-L121. The idea of this task is to check if we should not change the default recorder provider to [events.k8s.io/v1](http://events.k8s.io/v1): https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/383-new-event-api-ga-graduation/README.md#client-side-changes **TL'DR:** Note that some corev1...

camilamacedo86

✨ support for namespaced name predicate

6

Closes #1866.

prometherion

pkg/source Kind WaitForSync panics if called before Start

4

I got a panic from https://github.com/kubernetes-sigs/controller-runtime/blob/adc9fa96250106ebf0a3c589aa64e085e90870fd/pkg/source/source.go#L177 . There seems to be an assumption that https://github.com/kubernetes-sigs/controller-runtime/blob/adc9fa96250106ebf0a3c589aa64e085e90870fd/pkg/source/source.go#L121 runs earlier. I did not notice documentation that Start has to complete before WaitForSync is...

MikeSpreitzer