contributor-playground
contributor-playground copied to clipboard
Add a poem I Swallowed a Moon Made of Iron
What type of PR is this?
Uncomment only one
/kind <>
line, hit enter to put that in a new line, and remove leading whitespaces from that line:/kind api-change /kind bug /kind cleanup /kind design /kind documentation /kind failing-test /kind feature /kind flake
What this PR does / why we need it:
This is great a poem by Lizhi Xu, a poet and a worker in China.
Which issue(s) this PR fixes:
Fixes #N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
NONE
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: tangenti
Once this PR has been reviewed and has the lgtm label, please assign jberkus for approval by writing /assign @jberkus
in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Welcome @tangenti!
It looks like this is your first PR to kubernetes-sigs/contributor-playground 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/contributor-playground has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle stale
- Mark this issue or PR as rotten with
/lifecycle rotten
- Close this issue or PR with
/close
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle rotten
- Close this issue or PR with
/close
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
/remove-lifecycle rotten
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale
- Close this PR with
/close
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
/remove-lifecycle stale
/assign guineveresaenger
Do you really want to add file into shanghai
?
If you just want to practice submitting your pull request, please add <your github account>.md
file into remote/learners
directory.
If you would do so, I'll review it.
Hi @shu-mutou, what would be your concern over adding it to shanghai
?
Hello @tangenti, if i'm not mistaken the shanghai
and all relevant location directories are for people attending Kubecons at the respective locations. For people like us that follow the workshops and guides online we should make changes to the remote
directory. It is also mentioned in the README.
Hello @tangenti, if i'm not mistaken the
shanghai
and all relevant location directories are for people attending Kubecons at the respective locations. For people like us that follow the workshops and guides online we should make changes to theremote
directory. It is also mentioned in the README.
The README says do so in the remote directory or in the directory for each area or event
. I lived in Shanghai and it was natural for me to put the file in shanghai
, I suppose? If this was not intended, please correct the README accordingly :)
Yea afaik its not about where you are located but the location folders are about people that attended the Kubecons then. However someone needs to clarify this.