container-object-storage-interface-provisioner-sidecar icon indicating copy to clipboard operation
container-object-storage-interface-provisioner-sidecar copied to clipboard

Added EventRecorder to Provisioner Sidecar

Open shanduur opened this issue 1 year ago • 3 comments

During one of the SIG-Storage COSI meetings in February we discussed adding Event recording capabilities.

This is 3rd out of 3 pull requests across all repos (api/controller/provisioner-sidecar) with implementation of those changes.

Ref:

  • https://github.com/kubernetes-sigs/container-object-storage-interface-api/pull/67
  • https://github.com/kubernetes-sigs/container-object-storage-interface-api/pull/68

shanduur avatar Oct 18 '23 14:10 shanduur

Hi @shanduur. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 18 '23 14:10 k8s-ci-robot

/ok-to-test

xing-yang avatar Feb 05 '24 15:02 xing-yang

/approve

BlaineEXE avatar May 16 '24 17:05 BlaineEXE

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BlaineEXE, shanduur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 16 '24 17:05 k8s-ci-robot

/lgtm

BlaineEXE avatar May 16 '24 18:05 BlaineEXE