container-object-storage-interface-provisioner-sidecar icon indicating copy to clipboard operation
container-object-storage-interface-provisioner-sidecar copied to clipboard
verified publisher icon kubernetes-sigs

Fix reconciliation logic for existing and deleted objects

Open kvaps opened this issue 1 year ago • 7 comments

This PR addresses two cases:

  • Controller Restarts: When the controller restarts, it does not handle deletions for removed objects. Specifically, when an object with a deletion timestamp is passed into the Add() method, the deletion process was not handled correctly.

  • Recreation of Objects: The recreation of objects is not functioning as expected. For example, when an object is created, deleted, and then created again. In this scenario, the object may enter the Update method, where the creation process was not being handled properly.

kvaps avatar Jul 31 '24 18:07 kvaps

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kvaps Once this PR has been reviewed and has the lgtm label, please assign saad-ali for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 31 '24 18:07 k8s-ci-robot

/assign @saad-ali

kvaps avatar Aug 01 '24 00:08 kvaps

/assign @shanduur

kvaps avatar Aug 01 '24 14:08 kvaps

Hi! Thank you for your pull request. We are in the process of migration towards the monorepo, thus we will no longer accept any PRs to this repository. Please submit your changes to the https://github.com/kubernetes-sigs/container-object-storage-interface-api/tree/monorepo . Thanks!

shanduur avatar Aug 01 '24 14:08 shanduur

Sure done https://github.com/kubernetes-sigs/container-object-storage-interface-api/pull/86

kvaps avatar Aug 01 '24 15:08 kvaps

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Oct 30 '24 15:10 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Nov 29 '24 15:11 k8s-triage-robot